Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to embedded-hal-1.0.0 #207

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

irii
Copy link

@irii irii commented Jan 15, 2024

Hi! Thank you for helping out with SSD1306 development! Please:

  • Check that you've added documentation to any new methods
  • Rebase from master if you're not already up to date
  • Add or modify an example if there are changes to the public API
  • Add a CHANGELOG.md entry in the Unreleased section under the appropriate heading (Added, Fixed, Changed, etc)
  • Run rustfmt on the project with cargo fmt --all - CI will not pass without this step
  • Check that your branch is up to date with master and that CI is passing once the PR is opened

PR description

Updated to embedded-hal 1.0.0
Updated rust-version to 1.75 for display-interface package

  • Works on an CM4 module with I2C

Copy link
Collaborator

@jamwaffles jamwaffles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good aside from a tweak to the changelog. I appreciate the attention to detail in changing the CI config too - thanks!

CHANGELOG.md Show resolved Hide resolved
@jamwaffles
Copy link
Collaborator

P.s. CI is failing. I don't have much time to look into it right now so I'd appreciate it if you can see if you can fix the issues.

@irii
Copy link
Author

irii commented Jan 15, 2024

Thanks for the information. I will have a look by time. BR

@irii
Copy link
Author

irii commented Jan 15, 2024

The main reason of failing is the missing embedded-hal 1.0.0 support for stm32f1xx-hal. Maybe the examples should be migrated to stm32f4xx-hal (already has 1.0.0) or disable until an implementation is available.

@Sycrosity
Copy link

Sycrosity commented Apr 22, 2024

Any progress on this? I've been using my own embedded-hal v1.0.0 fork instead, however this seems a little more polished than mine. I would be happy to migrate the CI to another platform if needed!

@irii
Copy link
Author

irii commented Apr 22, 2024

@Sycrosity Currently not. All examples use the stm32f1xx-hal library. This library currently has no support for embedded hal 1.0 which is the main reason for the currently paused development.

@Sycrosity
Copy link

@Sycrosity Currently not. All examples use the stm32f1xx-hal library. This library currently has no support for embedded hal 1.0 which is the main reason for the currently paused development.

If it would help, I would happily switch the examples over to something like esp-hal, which I am quite familar with writing code for.

@ne0h
Copy link

ne0h commented May 23, 2024

Any progress so far? I would also much appreciate if this PR would be merged as it also solves my issue (#211).

@irii
Copy link
Author

irii commented May 23, 2024

Currently not because of lack of time.

A workaround would be to use https://github.com/ryankurte/embedded-hal-compat which has now offical support for embedded-hal 1.0.0

BR,
Ivan

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants