add get_pixel & toggle_pixel & extract shared code #194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
had to move track_changes call out of if block, therefore it will also run for invalid Y values (invalid X values where never caught anyway, they overflow into later Y values)
apply same fix we did for toggle_pixel to get_pixel, i.e. check the one bit and not all others instead: `(1 << bit)` gives a 1 for the bit we want to read, and 0 for all others. by applying a bit-wise AND operator between the current byte and this mask, we will only get something unequal to zero, if the bit we want to read is not zero: `byte & (1 << bit)`
…tion<Option<bool>>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi! Thank you for helping out with SSD1306 development! Please:
masterif you're not already up to dateCHANGELOG.mdentry in the Unreleased section under the appropriate heading (Added, Fixed, Changed, etc)rustfmton the project withcargo fmt --all- CI will not pass without this stepPR description
alternative to #193 that also contains a toggle_pixel function.