-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Search required 3 chars to return results, but appear to load with 1 and 2 #323
Comments
This is an intentional design decision - I felt like when the UI remained unchanged, it didn't signal to users that they should keep typing to get results. I'm curious what you expected/hoped to see? Did you expect that the UI remain blank until the user types 3 characters? Or did the word "Filtering" mislead you about what Stork is doing? |
Fair enough - it is honestly not terrible, and took me all of two seconds to figure out. Optimally, I feel as if the best solution would be to show nothing before 3 chars. However, if the user stops at 1 or 2 chars for say 1 second, prompt the user by showing "Please input 3 character minimum to search". |
In the version 2.0.0 branch, I'll allow the text displayed to be customizable. I still believe that "Filtering" is the best choice, but I understand that it might not be the best choice for everyone. |
Thanks for making it custumizable ^_^ "Filtering" sound to me like the system is activly doing something, and will produce a result when it is done. Do you not agree that "Filtering" just plain wrong, when in fact the system is waiting for input? |
Original issue can be found at MakieOrg/Makie.jl#2004.
Below is a copy of the original issue for convenience.
One and two character searches stay like this:
The moment i enter a third char, the result pops up.
It should not appear to load when it fact it is waiting for more input.
The text was updated successfully, but these errors were encountered: