From 75b58b59d720984664532d473c0865900aca23bb Mon Sep 17 00:00:00 2001 From: James Dalgleish Date: Fri, 8 Jan 2021 16:08:19 -0500 Subject: [PATCH] Moved plotly to suggests and didn't trigger a new warning/error. The NOTE stays unless I completely remove all plotly components from the package(which would make the shiny app unusable), but that's the best that I can do (and what sufficed for others to keep their package on CRAN). --- DESCRIPTION | 6 +++--- NAMESPACE | 7 ------- R/CNVScopeserver.R | 1 - 3 files changed, 3 insertions(+), 11 deletions(-) diff --git a/DESCRIPTION b/DESCRIPTION index 1d873a7..e88ac49 100644 --- a/DESCRIPTION +++ b/DESCRIPTION @@ -1,7 +1,7 @@ Package: CNVScope Type: Package Title: A Versatile Toolkit for Copy Number Variation Relationship Data Analysis and Visualization -Version: 3.5.5 +Version: 3.5.6 Date: 2021-01-08 Author: James Dalgeish, Yonghong Wang, Jack Zhu, Paul Meltzer Maintainer: James Dalgleish @@ -11,9 +11,9 @@ Imports: tidyr,reshape2,magrittr, jointseg,shiny,RCurl,foreach, GenomicInteractions,Matrix,OpenImageR,biomaRt,matrixStats, plyr,data.table,dplyr,numbers,rtracklayer, - doParallel,stringr,plotly + doParallel,stringr Suggests: knitr, remotes,pwr,ComplexHeatmap,rmarkdown, - HiCseg,igraph,visNetwork,circlize, + HiCseg,igraph,visNetwork,circlize,plotly, InteractionSet,GenomicRanges,GenomicFeatures,IRanges,rslurm, shinythemes,shinycssloaders,DT,logging,heatmaply, S4Vectors,BiocManager,shinyjs,htmltools,htmlwidgets, diff --git a/NAMESPACE b/NAMESPACE index e499797..6f6f360 100644 --- a/NAMESPACE +++ b/NAMESPACE @@ -54,13 +54,6 @@ importFrom(foreach,foreach) importFrom(ggplot2,scale_fill_gradient2) importFrom(jointseg,jointSeg) importFrom(matrixStats,colSds) -importFrom(plotly,add_histogram) -importFrom(plotly,add_trace) -importFrom(plotly,event_data) -importFrom(plotly,ggplotly) -importFrom(plotly,layout) -importFrom(plotly,plot_ly) -importFrom(plotly,renderPlotly) importFrom(plyr,ddply) importFrom(reshape2,colsplit) importFrom(rtracklayer,import.bed) diff --git a/R/CNVScopeserver.R b/R/CNVScopeserver.R index a4ab4ad..c678a6b 100644 --- a/R/CNVScopeserver.R +++ b/R/CNVScopeserver.R @@ -7,7 +7,6 @@ #' @rawNamespace import(shiny, except = c(runExample,renderDataTable)) #' @rawNamespace import(RCurl, except = reset) #' @rawNamespace import(data.table, except = c(melt, dcast)) -#' @importFrom plotly event_data renderPlotly layout ggplotly add_histogram add_trace plot_ly #' @param session The shiny session object for the application. #' @param input shiny server input #' @param output shiny server output