Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

closeProgressThreshold not work correctly #421

Open
RubyRook opened this issue Aug 15, 2024 · 0 comments
Open

closeProgressThreshold not work correctly #421

RubyRook opened this issue Aug 15, 2024 · 0 comments

Comments

@RubyRook
Copy link

Thank for your hard work.

I got problem with closeProgressThreshold, it work correctly when modal equal to screen height. But when modal heigh smaller than screen height i need to drag down modal nearly the edge of screen.

IMG_0330.MP4
bjartebore pushed a commit to bjartebore/modal_bottom_sheet that referenced this issue Nov 27, 2024
Fixed issue with closeProgressThreshold for smaller bottom sheets
6ea14aa 
When a ModalBottomSheets that due to its content is smaller than a full screen bottom sheet, the closeProgressThreshold is calculated based on how far the dialog has to move based on the percentage of the viewport/fullscreen dialog.

We need to adjust for this based on the height difference of the viewport and the rendered content within the bottom sheet dialog

Related issue: #jamesblasco#421
@bjartebore bjartebore mentioned this issue Nov 27, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@RubyRook