Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setting Priority Doesn’t Work #5

Open
Mr-Howard-Roark opened this issue May 2, 2019 · 3 comments
Open

Setting Priority Doesn’t Work #5

Mr-Howard-Roark opened this issue May 2, 2019 · 3 comments

Comments

@Mr-Howard-Roark
Copy link

When I use the set priority annotation in the docs it causes ingress rules to fail to be added to the ALB. Has anyone gotten this to work? It’s a perfect idea, but I don’t think it works.

@joonathan
Copy link

Make sure you are setting the priority as a string in yaml (in quotes).

@Mr-Howard-Roark
Copy link
Author

Mr-Howard-Roark commented May 2, 2019

Gotcha that worked! I think it would be good to include that in the example of the annotation. I also think it would be good to mention that without priority set the rules are sorted alphabetically by name. For a while we couldn’t figure out how they were being assembled in different orders when no priority is specified until we looked through the code. Regardless, this is such a great feature so thanks for implementing it!

To elaborate on the order confusion, we always wanted our port 80 redirect rule to have first priority. This rule has no domain name. It was confusing as to why sometimes it would appear first and sometimes not. It seems that its ingress name was being used as part of the sorting.

@ZillaG
Copy link

ZillaG commented Mar 9, 2021

It works for me. Application load balancing on Amazon EKS say it has to be in this format.

alb.ingress.kubernetes.io/group.order: <'10'>

So I have this in my manifest file

alb.ingress.kubernetes.io/group.order: {{ include "microserviceChart.IngressGroupOrder" . }}

and this in my templates/_helpers.tpl file

{{/*
Function to get ingress path
*/}}
{{- define "microserviceChart.IngressGroupOrder" -}}
"<'
{{- .Values.ingress.listenerRulePriority -}}
'>"
{{- end }}

and of course this in my values.yaml file

ingress:
  listenerRulePriority: ""

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants