Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Launch nrepl server along with the test runner #77

Open
vemv opened this issue Aug 19, 2018 · 2 comments
Open

Launch nrepl server along with the test runner #77

vemv opened this issue Aug 19, 2018 · 2 comments

Comments

@vemv
Copy link

vemv commented Aug 19, 2018

Hi!

Normally I connect Emacs (which might as well be any other editor/IDE) to an external nrepl process, for reliability: I simply lein repl in iTerm with a fixed port (as per profiles.clj).

The only problem being, a lein repl + a lein test-refresh is wasteful: that's 2 JVMs.

So I was thinking, what if lein test-refresh offers a :start-nrepl CLI option.

Does it sound like a feature your library could accept as a PR?

Cheers - Victor

@jakemcc
Copy link
Owner

jakemcc commented Aug 19, 2018

Thanks for asking. I'd accept a PR for this feature. This request has come up a couple times (maybe not on GitHub but in conversations at least).

I've been hesitant to add it because I don't think I'd enjoy being connected to a REPL where something else (in this case, lein-test-refresh) is in control of when the REPL's state changes.

@vemv
Copy link
Author

vemv commented Aug 19, 2018

I've been hesitant to add it because I don't think I'd enjoy being connected to a REPL where something else (in this case, lein-test-refresh) is in control of when the REPL's state changes.

Good observation, the end result of my effort might be messier than I thought.

I'm trying a solution at Lein level first nrepl/lein-nrepl#4 , as the problem seems generic. Might close this issue if that one works fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants