-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Missing status codes in Response class #993
Comments
The reason is there: "@mithunsasidharan Are you still interested in working on this? If so, could you rebase against `3.1-SNAPSHOT" and update the pull request accordingly?" Needs to be resubmitted for 3.1 using the correct branch. |
@spericas : Is this something thats already been pickedup ? If not I'd like to work on it ! |
@mithunsasidharan Feel free to work on it. See previous work and suggestion by @reschke. |
@mithunsasidharan Any update on this work? |
If @mithunsasidharan isn't responding, I'd be willing to tackle this. |
@jelemux There wer months of waiting, so I'd say, he lost interest. Please go ahead, we would be delighted to receive your PR. |
Thank you @mkarg! I suppose there's a reason that there are no 100 status codes in there, right? |
JAX-RS is not an HTTP wrapper (like Servlet API), it is solely and specifically a REST API, hence not all the codes make sense. So I would say, only those should be added that really are of general interest for REST applications. |
Sorry for the late response, I've caught the flu and then had a week of vacation after I recovered. I went through all the missing status codes and singled those out that MAY be of general interest for REST applications. In short, those are the status codes that may be of general interest to REST applications:
I think it is best to create separate PRs for each of these since there may be arguments against some of these that don't concern the others. |
What may not be of general interest to REST applications but still came up is WebDAV.
Because additional status codes can be added by creating an implementation of |
@jelemux I agree with your assessment on the wiki. I'm +1 for adding 300, 308 and 451. I'm +0 or -1 on the rest. I also agree that separate PRs would be the most expedient - I suspect that 308 will be the easiest to get in, while 300 and 451 might take some discussion. Thanks for putting this together! I think it will also help us in the future (for example, when JAX-RS officially supports HTTP/2, etc.) to know which HTTP response codes we should add. |
I never needed 203; I doubt that it is actually of common use. WebDAV is definitively an outdated technology which we should not start to explicitly support. In fact, if someone wants to use WebDAV with JAX-RS, he can simply use the ready-to-use extension WebDAV for JAX-RS which (for those who don't know) was the reason for me adding the |
Now that the codes have been added, I think this can be closed now. |
See #582, which was closed for reasons that escape me.
There are likely more status codes missing, see the IANA registry at https://www.iana.org/assignments/http-status-codes/http-status-codes.xhtml. It would also be good to update comments to refer to current RFCs, not obsoleted ones.
cc: @mkarg
The text was updated successfully, but these errors were encountered: