Change CMP/BMP tests to be optional via unique keyword (or profile)

[scottmarlow]

As per https://eclipse-ee4j.github.io/jakartaee-platform/jakartaee10/JakartaEE10ReleasePlan, Jakarta Enterprise Beans tests that use entity beans (CMP and BMP) need to be be optional via unique keywords (or profiles). Note that the release plan also mentions these tests may need to be removed instead (depending on outcome of EclipseFdn/EFSP#22).

[scottmarlow]

Note that Embeddable EJB Container tests should also be optional individually as well. To find these tests, take a look at:

jakartaee-tck/src $ grep -rli createEJBContainer
com/sun/ts/tests/signaturetest/signature-repository/jakarta.ejb.sig_4.0_se11
com/sun/ts/tests/common/vehicle/ejbembed/EJBEmbedRunner.java
com/sun/ts/tests/ejb30/lite/packaging/embed/provider/TSEJBContainerProviderImpl.java
jakartaee-tck/src $ vim grep -rli ejbembed
jakartaee-tck/src $ grep -rli ejbembed
com/sun/ts/lib/harness/TSScript.java
com/sun/ts/lib/harness/ProfileHelper.java
com/sun/ts/lib/harness/TSTestFinder.java
com/sun/ts/tests/common/vehicle/VehicleRunnerFactory.java
com/sun/ts/tests/common/vehicle/ejbembed/EJBEmbedRunner.java
com/sun/ts/tests/common/vehicle/ejbembed/EmbeddableEJBProcess.java
com/sun/ts/tests/common/vehicle/ejbembed/InjectionResolver.java
com/sun/ts/tests/common/vehicle/ejbliteshare/EJBLiteClientIF.java
com/sun/ts/tests/ejb30/lite/lookup/common/ClientBase.java
com/sun/ts/tests/ejb30/lite/stateful/timeout/common/StatefulTimeoutIF.java
com/sun/ts/tests/ejb30/lite/tx/cm/stateful/rw/TestBean.java
com/sun/ts/tests/ejb30/lite/tx/cm/stateful/rw/TxBean.java
com/sun/ts/tests/ejb30/lite/tx/cm/singleton/rw/TestBean.java
com/sun/ts/tests/ejb30/lite/tx/cm/singleton/rw/TxBean.java
com/sun/ts/tests/ejb30/lite/tx/cm/singleton/rw/Client.java
com/sun/ts/tests/ejb30/lite/naming/context/Client.java
com/sun/ts/tests/ejb30/lite/xmloverride/ejbref/Client.java
com/sun/ts/tests/ejb30/lite/basic/common/BasicBeanHelper.java
com/sun/ts/tests/ejb30/lite/packaging/embed/classloader/annotated/Client.java
com/sun/ts/tests/ejb30/lite/packaging/embed/classloader/annotated/build.xml
com/sun/ts/tests/ejb30/lite/packaging/embed/classloader/descriptor/ejbembed_three_ejb.xml
com/sun/ts/tests/ejb30/lite/packaging/embed/classloader/descriptor/Client.java
com/sun/ts/tests/ejb30/lite/packaging/embed/classloader/descriptor/build.xml
com/sun/ts/tests/ejb30/lite/packaging/embed/classloader/descriptor/ejbembed_two_ejb.xml
com/sun/ts/tests/ejb30/lite/packaging/embed/provider/build.xml
com/sun/ts/tests/ejb30/common/lite/EJBLiteClientBase.java

[scottmarlow]

It looks like the EJB Lite feature is already optional via https://github.com/eclipse-ee4j/jakartaee-tck/blob/master/install/jakartaee/other/vehicle.properties#L140:
com/sun/ts/tests/ejb30/lite = ejbliteservlet ejbliteservlet2 ejblitejsf ejblitejsp ejbembed

As well as https://github.com/eclipse-ee4j/jakartaee-tck/blob/master/install/jakartaee/other/vehicle.properties#L156 for ejb32/lite and https://github.com/eclipse-ee4j/jakartaee-tck/blob/master/install/jakartaee/other/vehicle.properties#L164 for ejb32/timer

[scottmarlow]

Removing the EE10 label as this seems out of scope now.

[dblevins]

Confirming that the CMP/BMP tests should have already been optional. Similarly, the embedded EJB container was made optional in Java EE 7.

Short of removing the tests, there shouldn't be anything to do. We'd need to establish a separate EJB TCK before we could actually remove any tests as these APIs are still implemented and shipped as addons/additional features/additional specs supported.

[brideck]

Note: There are 16 test packages that contain some tests that require entity beans alongside others that do not. Some work could conceivably be done to divide these packages so vendors that don't support entity beans had the ability to run and report these tests.

ejb/ee/bb/localaccess/mdbqaccesstest
ejb/ee/bb/localaccess/mdbtaccesstest
ejb/ee/bb/localaccess/sbaccesstest
ejb/ee/bb/localaccess/webaccesstest
ejb/ee/bb/session/stateful/argsemantics
ejb/ee/bb/session/stateless/argsemantics
ejb/ee/deploy/mdb/ejblink/single
ejb/ee/deploy/mdb/ejblink/singleT
ejb/ee/deploy/mdb/ejbref/single
ejb/ee/deploy/mdb/ejbref/singleT
ejb/ee/deploy/session/stateful/ejblink/single
ejb/ee/deploy/session/stateful/ejbref/single
ejb/ee/deploy/session/stateless/ejblink/single
ejb/ee/deploy/session/stateless/ejbref/single
ejb/ee/timer/mdb
ejb/ee/timer/session/stateless/cm

[scottmarlow]

@dblevins should we discuss #947 on [email protected] and whether the proposed change should be included for EE 10 or after EE 10?