Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mumble-Dark missing icons #80

Open
Rockz1152 opened this issue Dec 10, 2024 · 4 comments
Open

Mumble-Dark missing icons #80

Rockz1152 opened this issue Dec 10, 2024 · 4 comments

Comments

@Rockz1152
Copy link

Looks like after 905049e the theme file no longer includes the icons from the screenshot in the README.
The theme file is also several hundred kilobytes smaller than the previous release. (13.1 KB vs 373 KB)

Not sure if this was an intentional change but figured I would open an issue to let someone know.

@cornelcristea
Copy link

Hello @Rockz1152 !

The commit mentioned by you is mine and maybe I did something wrong when I built the theme.
Please, could you take some screenshots for this issue?

Many thanks!

@Rockz1152
Copy link
Author

Sure, here is a v2.3 Screenshot.

Image

Here is one after the update.

Image

Let me know if you need anything else.

@cornelcristea
Copy link

Oh, I see what you mean.

In build script I observed that are present 2 build commands that have as arguments a icons folder and for one of them, this folder is missing.
I will have look into this in next days but probably, when 2.3 version was build, the author used other icons and after that they was updated with these.

I will come back to you!

@cornelcristea
Copy link

@Rockz1152 I didn't find the reason why the icons from v2.3 are different than my fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants