Skip to content

Commit ecbae67

Browse files
authored
Prepare release 1.56.0 (#5321)
* coincidentally GitHub runners removed `docker-compose` (v1) command on Apr-1, so I added a commit that changes everything to use `docker compose` (v2) * the all-in-one integration tests were failing because jaeger logo file in ui static assets got a different hash for some reason. I changed the test to read the actual file name from index.html and then try to load it. --------- Signed-off-by: Yuri Shkuro <[email protected]>
1 parent 055fcd7 commit ecbae67

File tree

8 files changed

+69
-27
lines changed

8 files changed

+69
-27
lines changed

CHANGELOG.md

Lines changed: 35 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,41 @@ run `make changelog` to generate content
2121

2222
</details>
2323

24+
1.56.0 (2024-04-02)
25+
-------------------
26+
27+
### Backend Changes
28+
29+
#### ⛔ Breaking Changes
30+
31+
* Fix hotrod instructions ([@yurishkuro](https://github.com/yurishkuro) in [#5273](https://github.com/jaegertracing/jaeger/pull/5273))
32+
33+
#### 🐞 Bug fixes, Minor Improvements
34+
35+
* Refactor healthcheck signalling between server and service ([@WillSewell](https://github.com/WillSewell) in [#5308](https://github.com/jaegertracing/jaeger/pull/5308))
36+
* Docs: badger file permission as non-root service ([@tico88612](https://github.com/tico88612) in [#5282](https://github.com/jaegertracing/jaeger/pull/5282))
37+
* [kafka-consumer] add support for setting fetch message max bytes ([@sappusaketh](https://github.com/sappusaketh) in [#5283](https://github.com/jaegertracing/jaeger/pull/5283))
38+
* [chore] remove repetitive words ([@tgolang](https://github.com/tgolang) in [#5265](https://github.com/jaegertracing/jaeger/pull/5265))
39+
* Fix zipkin spanformat ([@fyuan1316](https://github.com/fyuan1316) in [#5261](https://github.com/jaegertracing/jaeger/pull/5261))
40+
* [kafka-producer] support setting max message size ([@sappusaketh](https://github.com/sappusaketh) in [#5263](https://github.com/jaegertracing/jaeger/pull/5263))
41+
42+
#### 🚧 Experimental Features
43+
44+
* [jaeger-v2] add support for opensearch ([@akagami-harsh](https://github.com/akagami-harsh) in [#5257](https://github.com/jaegertracing/jaeger/pull/5257))
45+
* [jaeger-v2] add support for cassandra ([@Pushkarm029](https://github.com/Pushkarm029) in [#5253](https://github.com/jaegertracing/jaeger/pull/5253))
46+
47+
#### 👷 CI Improvements
48+
49+
* Allow go-leak linter to fail ci ([@yurishkuro](https://github.com/yurishkuro) in [#5316](https://github.com/jaegertracing/jaeger/pull/5316))
50+
* [jaeger-v2] add grpc storage backend integration test ([@james-ryans](https://github.com/james-ryans) in [#5259](https://github.com/jaegertracing/jaeger/pull/5259))
51+
* Github actions added to block prs from fork/main branch ([@varshith257](https://github.com/varshith257) in [#5272](https://github.com/jaegertracing/jaeger/pull/5272))
52+
53+
54+
### 📊 UI Changes
55+
56+
* UI pinned to version [1.40.0](https://github.com/jaegertracing/jaeger-ui/blob/main/CHANGELOG.md#v1400-2024-04-02).
57+
58+
2459
1.55.0 (2024-03-04)
2560
-------------------
2661
### Backend Changes

RELEASE.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -60,8 +60,8 @@ Here are the release managers for future versions with the tentative release dat
6060
6161
| Version | Release Manager | Tentative release date |
6262
|---------|-----------------|------------------------|
63-
| 1.56.0 | @yurishkuro | 3 April 2024 |
6463
| 1.57.0 | @albertteoh | 1 May 2024 |
6564
| 1.58.0 | @pavolloffay | 5 June 2024 |
6665
| 1.59.0 | @joe-elliott | 3 July 2024 |
67-
| 1.55.0 | @jkowall | 7 August 2024 |
66+
| 1.60.0 | @jkowall | 7 August 2024 |
67+
| 1.61.0 | @yurishkuro | 3 Sep 2024 |

cmd/all-in-one/all_in_one_test.go

Lines changed: 19 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,7 @@ import (
2121
"io"
2222
"net/http"
2323
"os"
24+
"regexp"
2425
"strings"
2526
"testing"
2627
"time"
@@ -85,22 +86,29 @@ func healthCheck(t *testing.T) {
8586
}
8687

8788
func checkWebUI(t *testing.T) {
88-
t.Run("logo", func(t *testing.T) {
89-
resp, err := http.Get(queryAddr + "/static/jaeger-logo-jWbKFHZJ.svg")
89+
resp, err := http.Get(queryAddr + "/")
90+
require.NoError(t, err)
91+
require.NotNil(t, resp)
92+
defer resp.Body.Close()
93+
assert.Equal(t, http.StatusOK, resp.StatusCode)
94+
bodyBytes, err := io.ReadAll(resp.Body)
95+
require.NoError(t, err)
96+
body := string(bodyBytes)
97+
t.Run("Static_files", func(t *testing.T) {
98+
pattern := regexp.MustCompile(`<link rel="shortcut icon"[^<]+href="(.*?)"`)
99+
match := pattern.FindStringSubmatch(body)
100+
require.Len(t, match, 2)
101+
url := match[1]
102+
t.Logf("Found favicon reference at %s", url)
103+
104+
resp, err := http.Get(queryAddr + "/" + url)
90105
require.NoError(t, err)
91106
require.NotNil(t, resp)
92107
defer resp.Body.Close()
93108
assert.Equal(t, http.StatusOK, resp.StatusCode)
94109
})
95-
t.Run("React app", func(t *testing.T) {
96-
resp, err := http.Get(queryAddr + "/")
97-
require.NoError(t, err)
98-
require.NotNil(t, resp)
99-
defer resp.Body.Close()
100-
assert.Equal(t, http.StatusOK, resp.StatusCode)
101-
body, err := io.ReadAll(resp.Body)
102-
require.NoError(t, err)
103-
assert.Contains(t, string(body), `<div id="jaeger-ui-root"></div>`)
110+
t.Run("React_app", func(t *testing.T) {
111+
assert.Contains(t, body, `<div id="jaeger-ui-root"></div>`)
104112
})
105113
}
106114

crossdock/rules.mk

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -5,16 +5,15 @@ JAEGER_COLLECTOR_HC_PORT ?= 14269
55

66
.PHONY: crossdock
77
crossdock:
8-
docker-compose -f $(JAEGER_COMPOSE_YAML) -f $(XDOCK_YAML) kill
9-
docker-compose -f $(JAEGER_COMPOSE_YAML) -f $(XDOCK_YAML) rm -f test_driver
10-
JAEGER_COLLECTOR_HC_PORT=${JAEGER_COLLECTOR_HC_PORT} docker-compose -f $(JAEGER_COMPOSE_YAML) -f $(XDOCK_YAML) run crossdock 2>&1 | tee run-crossdock.log
8+
docker compose -f $(JAEGER_COMPOSE_YAML) -f $(XDOCK_YAML) kill
9+
docker compose -f $(JAEGER_COMPOSE_YAML) -f $(XDOCK_YAML) rm -f test_driver
10+
JAEGER_COLLECTOR_HC_PORT=${JAEGER_COLLECTOR_HC_PORT} docker compose -f $(JAEGER_COMPOSE_YAML) -f $(XDOCK_YAML) run crossdock 2>&1 | tee run-crossdock.log
1111
grep 'Tests passed!' run-crossdock.log
1212

1313
.PHONE: crossdock-logs
1414
crossdock-logs:
15-
docker-compose -f $(JAEGER_COMPOSE_YAML) -f $(XDOCK_YAML) logs
15+
docker compose -f $(JAEGER_COMPOSE_YAML) -f $(XDOCK_YAML) logs
1616

1717
.PHONE: crossdock-clean
1818
crossdock-clean:
19-
docker-compose -f $(JAEGER_COMPOSE_YAML) -f $(XDOCK_YAML) down
20-
19+
docker compose -f $(JAEGER_COMPOSE_YAML) -f $(XDOCK_YAML) down

docker-compose/kafka/README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
# Sample configuration with Kafka
22

3-
This `docker-compose` environment provides a sample configuration of Jaeger depoyment utilizing collector-Kafka-injester pipeline. Storage is provided by the `jageer-remote-storage` service running memstore.
3+
This `docker compose` environment provides a sample configuration of Jaeger depoyment utilizing collector-Kafka-injester pipeline. Storage is provided by the `jageer-remote-storage` service running memstore.
44

55
Jaeger UI can be accessed at http://localhost:16686/, as usual, and refreshing the screen should produce internal traces.
66

examples/grafana-integration/README.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22

33
This example combines the Hot R.O.D. demo application ([examples/hotrod/](../hotrod/)) with Grafana, Loki and Prometheus integration, to demonstrate logs, metrics and traces correlation.
44

5-
## Running via `docker-compose`
5+
## Running via `docker compose`
66

77
### Prerequisites
88

@@ -20,7 +20,7 @@ grafana/loki-docker-driver:latest \
2020

2121
### Run the services
2222

23-
`docker-compose up`
23+
`docker compose up`
2424

2525
### Access the services
2626
* HotROD application at http://localhost:8080
@@ -52,4 +52,4 @@ Additionally, there are graphs for each service, visualizing the rate of the req
5252

5353
### Clean up
5454

55-
`docker-compose down`
55+
`docker compose down`

examples/hotrod/README.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -19,14 +19,14 @@ As of Jaeger v1.42.0 this application was upgraded to use the OpenTelemetry SDK
1919

2020
## Running
2121

22-
### Run everything via `docker-compose`
22+
### Run everything via `docker compose`
2323

2424
* Download `docker-compose.yml` from https://github.com/jaegertracing/jaeger/blob/main/examples/hotrod/docker-compose.yml
2525
* Optional: find the latest Jaeger version (see https://www.jaegertracing.io/download/) and pass it via environment variable `JAEGER_VERSION`. Otherwise `docker compose` will use the `latest` tag, which is fine for the first time you download the images, but once they are in your local registry the `latest` tag is never updated and you may be running stale (and possibly incompatible) verions of Jaeger and the HotROD app.
2626
* Run Jaeger backend and HotROD demo, e.g.:
27-
* `JAEGER_VERSION=1.52 docker-compose -f path-to-yml-file up`
27+
* `JAEGER_VERSION=1.52 docker compose -f path-to-yml-file up`
2828
* Access Jaeger UI at http://localhost:16686 and HotROD app at http://localhost:8080
29-
* Shutdown / cleanup with `docker-compose -f path-to-yml-file down`
29+
* Shutdown / cleanup with `docker compose -f path-to-yml-file down`
3030

3131
Alternatively, you can run each component separately as described below.
3232

0 commit comments

Comments
 (0)