Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Path is a different color from one in minimap #7

Open
jackhumbert opened this issue Jun 11, 2022 · 27 comments
Open

Path is a different color from one in minimap #7

jackhumbert opened this issue Jun 11, 2022 · 27 comments

Comments

@jackhumbert
Copy link
Owner

If you notice this, you can run these commands in CET to see which variant it is - I can then build it into the code so the correct color is selected.

Quests:

print(InWorldNavigation.GetInstance().questVariant)

Points of Interest:

print(InWorldNavigation.GetInstance().poiVariant)

It should display one of these - put the variant's name & the color it should be here, and I'll add it and check it off :)

@Thortok
Copy link

Thortok commented Jun 11, 2022

Will do. I do like the color to match!

@Thortok
Copy link

Thortok commented Jun 11, 2022

gamedataMappinVariant : SabotageVariant (94) - Gig color (green)

@Thortok
Copy link

Thortok commented Jun 11, 2022

gamedataMappinVariant : ClientInDistressVariant (16) - Gig color (green)

@Thortok
Copy link

Thortok commented Jun 11, 2022

gamedataMappinVariant : ThieveryVariant (117) - Gig color (green)

@Thortok
Copy link

Thortok commented Jun 11, 2022

gamedataMappinVariant : HuntForPsychoVariant (66) - cyberpsycho color (green)

@Thortok
Copy link

Thortok commented Jun 11, 2022

gamedataMappinVariant : GangWatchVariant (56) - assault in progress, NCPD color (light blue)

@Thortok
Copy link

Thortok commented Jun 11, 2022

gamedataMappinVariant : HiddenStashVariant (64) - Reported crime, NCPD color (light blue)

@Thortok
Copy link

Thortok commented Jun 11, 2022

gamedataMappinVariant : Zzz06_NCPDGigVariant (126) - Reported crime followup quest, NCPD gig color (light green, not sure if the exact same as normal gig color)

@Thortok
Copy link

Thortok commented Jun 11, 2022

gamedataMappinVariant : GangWatchVariant (56) - You must have updated this in the version I just tested, but it's not a color match, looks like you put dark blue (like fast travel point or tarot card) instead of the correct light blue/cyan (like an NCPD location)

@Thortok
Copy link

Thortok commented Jun 11, 2022

gamedataMappinVariant : OutpostVariant (85) - Suspected Organized Crime Activity - NCPD poi - cyan (gonna call it cyan instead of light blue)

@Thortok
Copy link

Thortok commented Jun 11, 2022

Another one that got mapped too dark a blue, needs to be cyan

gamedataMappinVariant : HiddenStashVariant (64) - Reported crime, NCPD color (cyan)

@Thortok
Copy link

Thortok commented Jun 11, 2022

Cyan is the correct color now but it's so bright it still looks wrong.

image

@Thortok
Copy link

Thortok commented Jun 11, 2022

Looks better when the scanner is on

image

@Thortok
Copy link

Thortok commented Jun 11, 2022

(Hard to take screenshots in HDR, hope those help)

@jackhumbert
Copy link
Owner Author

Perfect - thanks! I haven't found a NCPD event to test the cyan yet haha.

@Thortok
Copy link

Thortok commented Jun 11, 2022

NCPD events are all over the map.... however, the default filter has them off by default. Did you turn them on?

@Thortok
Copy link

Thortok commented Jun 11, 2022

image
Make sure the NCPD scanner is turned on....as well as everything else, for testing purposes at least

@jackhumbert
Copy link
Owner Author

Ahh - I keep on using my 100% save to test :) they don't respawn do they?

@Thortok
Copy link

Thortok commented Jun 12, 2022

Nope once you clear them they're gone forever lol

@Thortok
Copy link

Thortok commented Jun 12, 2022

gamedataMappinVariant : BountyHuntVariant (13) - gig color (Green)

@Thortok
Copy link

Thortok commented Jun 14, 2022

So this was during a Johnny quest. Johnny quests have an interesting bug. The UI is supposed to change color, but it doesn't always happen. If you die/reload during a Johnny quest that usually triggers it.

With the changed UI, quests are cyan instead of yellow. How to tell if the UI has successfully changed over or not, I don't know.

Anyway, ran the script and it reported this:

gamedataMappinVariant : ExclamationMarkVariant (49)

So make this cyan, maybe? But it won't look right when the UI is still the normal non-Johnny type.

image

I also don't yet know if this is used outside of Johnny quests in which case it is correctly colored yellow for those. I'm only checking colors that are 'wrong' and not every quest, so...

@Thortok
Copy link

Thortok commented Jun 18, 2022

gamedataMappinVariant : DefaultQuestVariant (25)

This was during a Johnny quest, so, cyan... Makes me think you'll have to do some Johnny-quest-detection in order to swap color schemes.

image

@Thortok
Copy link

Thortok commented Jun 27, 2022

image
gamedataMappinVariant : DefaultQuestVariant (25)

@Thortok
Copy link

Thortok commented Nov 11, 2023

image

gamedataMappinVariant : Zzz09_CourierSandboxActivityVariant (129)

Shows white, should be teal.

@Thortok
Copy link

Thortok commented Nov 11, 2023

image

gamedataMappinVariant : Zzz01_CarForPurchaseVariant (121)

Shows teal, should be white.

@Thortok
Copy link

Thortok commented Nov 15, 2023

image

gamedataMappinVariant : Zzz12_WorldEncounterVariant (133)

Shows white, should be teal.

@Thortok
Copy link

Thortok commented Feb 3, 2024

With Seberoth's help, fixed and updated colors
in_world_navigation.zip

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants