Skip to content
This repository has been archived by the owner on Jul 22, 2019. It is now read-only.

Pokemon listed in "evolve_before_transfer" does not evolve #1204

Open
casper-gh opened this issue Aug 21, 2016 · 33 comments
Open

Pokemon listed in "evolve_before_transfer" does not evolve #1204

casper-gh opened this issue Aug 21, 2016 · 33 comments

Comments

@casper-gh
Copy link

Description:
Pokemon listed in "evolve_before_transfer" does not evolve, instead it keeps all those pokemon causing POKEMON_INVENTORY_FULL

Steps to reproduce:

  1. Add pokemon to evolve_before_transfer
  2. Run the bot
  3. All pokemon listed in evolve_before_transfer are kept causing POKEMON_INVENTORY_FULL

Expected behavior:
Pokemon should be evolved and then transferred

Actual behavior:
Pokemon does not evolve

Version:
0.6.0

Operating System:
Ubuntu

Java version:
Latest

Leave this sentence in your issue as proof that you have read and used this template.

My config: http://pastebin.com/GC8Ggh7u

@FrancYescO
Copy link
Contributor

It willl wait for
evolve_stack_limit=10 before start evolving

@casper-gh
Copy link
Author

@FrancYescO I don't really understand what it means, but I have like 30+ Pidgeys and bot still doesn't evolve

@FrancYescO
Copy link
Contributor

Sometime it will log "Pokémon ready for stack evolve xx" probably you need more candys?

@casper-gh
Copy link
Author

I got Pokémon ready for stack evolve 0, but I have 5K + of Pidgey candies

@FrancYescO
Copy link
Contributor

Pidgy is also here..

obligatory_transfer=DODUO,RATTATA,CATERPIE,PIDGEY

@casper-gh
Copy link
Author

but doesn't evolve_before_transfer will evolve the pokemon first? So what you're saying is I cannot define the same pokemon in both obligatory_transfer and evolve_before_transfer ?

@FrancYescO
Copy link
Contributor

How can a Pokémon be evolved if you "obligatory" throw away?

@casper-gh
Copy link
Author

The thing is, the bot neither throws those pokemon away nor evolve it, all those pokemon are retained making my pokemon inventory full

@FrancYescO
Copy link
Contributor

Post your Pokémon list

@casper-gh
Copy link
Author

Sorry I manually evolved them all, will try to get the list when pokemon are full again

@casper-gh
Copy link
Author

Ok I got the pokemon list here http://pastebin.com/87Y8RrcJ

You can see there's a lot of Pidgeys...

@FrancYescO
Copy link
Contributor

and still Pokémon ready for stack evolve 0 ???? if you don't see this incrementing and reaching 10 (as you config require) you will never get an evolve.

@casper-gh
Copy link
Author

that's why it's a bug?

@FrancYescO
Copy link
Contributor

FrancYescO commented Aug 22, 2016

yeah but to me is working good, so wee need to find what's wrong with your config.

@casper-gh
Copy link
Author

can you share your config?

@FrancYescO
Copy link
Contributor

"obligatoryTransfer" : [ ],
"evolveBeforeTransfer" : [ "CATERPIE", "RATTATA", "WEEDLE", "PIDGEY", "ZUBAT" ],
"evolveStackLimit" : 70,
"useLuckyEgg" : 1,

butw probably somehow related to
#1088

@casper-gh
Copy link
Author

So don't put anything in obligatory transfer?

@FrancYescO
Copy link
Contributor

no, i don't want to obligatory transfer.

@FrancYescO
Copy link
Contributor

also make sure to edit the json file if present and not proprieties one.

@casper-gh
Copy link
Author

can you share the entire json template?

@FrancYescO
Copy link
Contributor

i'm using develop with some pr merged so some config will be in conflict.

what can affect this issue is already up

@MacDogg
Copy link

MacDogg commented Aug 22, 2016

Having the same issue.
Config info related to this:
obligatory_transfer=CATERPIE,RATTATA,WEEDLE,PIDGEY (this seems to be ignored because none of these are transferred, they are all still in my inventory)
evolve_before_transfer=CATERPIE,RATTATA,WEEDLE,PIDGEY
evolve_stack_limit=30
use_lucky_egg=1
I currently have 14 Weedle, 15 Rattata, 23 Pidgey and 9 Caterpie. When I start the bot with the above settings nothing happens, they aren't transferred, they aren't evolved.
I have 582 Weedle candy so I can evolve 48. I have 942 Rattata candy so I can evolve 37. I have 1256 Pidgey candy so I can evolve 104. I have 297 Catepie candy so I can evolve 24. I have 5 lucky eggs.
I even cleared the obligatory_transfer line and still nothing happens.

@casper-gh
Copy link
Author

in my case, the config on obligatory_transfer works fine, just evolve_before_transfer isn't working

@FrancYescO
Copy link
Contributor

the crucial thing is

"evolveStackLimit" : 70,

no evolve are done until we have enought pokemon to evolve defined by this value

obligatory_transfer pokemon are kept if also in the evolve_before_transfer (still a nosense to have in both list)

@casper-gh
Copy link
Author

My new config looks like this:

obligatory_transfer=DODUO
evolve_before_transfer=CATERPIE,RATTATA,WEEDLE,PIDGEY,DROWZEE

But after 8 hrs botting, still getting full pokemon inventory because all the above pokemon are kept.

@FrancYescO
Copy link
Contributor

FrancYescO commented Aug 22, 2016

if in your log you see

Stack of pokemon ready to evolve: 0

this is the issue but this can also mean you have not enought candy.. probably i need a full session log to understand something, also waiting for the next version might have solved this issue due to some changes done in the evolve func.

@th3n3rd
Copy link

th3n3rd commented Aug 22, 2016

I had the same issue with Drowzee, like 1k+ candies and fill up the inventory. I've also tried to put it in the obligatory transfer and also in the list of "evolve before transfer" but I got into another issue where I got an arithmetic exception (division by zero). I believe there is some problem with the candies evaluation. I am using 0.6 by the way.

@casper-gh
Copy link
Author

Yes, that's what I have

@th3n3rd
Copy link

th3n3rd commented Aug 22, 2016

One thing that helps, just tried, is to use the max_pokemon_amount parameter. If you set the latter to 1 the bot will discard all the duplicate leaving only one pokemon per type but for the ones listed within evolve_before_transfer list! (unless you need candies of course).

@Sieberkev
Copy link
Collaborator

Can you get the most recent develop version (and not 0.6.0 release) and test it again? Several pieces of code for the evolving got improved.

@casper-gh
Copy link
Author

I'm waiting for the release build, anyway I think the issue mostly happens if the bot is scheduled to restart periodically.

@kiaph
Copy link

kiaph commented Aug 31, 2016

Question:

details.

Player want only 3 of each pokemon max.
Players wants to evolve at stack 30
Player obtains 4 pidgey, does bot throw away pidgey, or keep it knowing it is already doomed to be transfered after it evolves.

Realistically the player keeps it as it is a "evolve&&transfer pokemon", so hoping the bot is able to see this as well.

Sorry for hijacking this thread, I didn't see someone complaining for either side in the issue threads so I chose the closes one on topic to ask, however I am going to use these settings and see what happens.

@FrancYescO
Copy link
Contributor

Will keep it.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants