-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Minor BitmapFont code architecture issues #2221
Comments
The bitmap font/text code is a great example of bad code. It does back flips and hand springs to seemingly avoid creating "garbage"... but then ends up creating hidden garbage instead, being overly complicated, and hurting its own performance. It also confounds usability improvements like easily being able to detect 'clicked character' and stuff like that. Some of the problems are even more fundamental than what you point out. The whole thing is in need of a rewrite. I started one once but it's a big job. |
Minor BitmapFont code architecture issues. Functionally it works just fine :)
arrayBased
. It never uses it, it is always true. Some of these have been deprecated already in the hierarchy, maybe this one should also be. Now it is just confusingjmonkeyengine/jme3-core/src/main/java/com/jme3/font/BitmapTextPage.java
Line 153 in ea715d8
pageQuads
isLinkedList
, and the said method heavily usesget(int)
on it. This is not great, n^2 problem, right?jmonkeyengine/jme3-core/src/main/java/com/jme3/font/ColorTags.java
Line 68 in ea715d8
get(int)
.LinkedList is probably utilized since its steady
add
performance and that it doesn't leave potentially big arrays behind (if your text goes from being 2,147,483,647 to 1 character... you'll never recover). At least point 2 could be covered by afor each
loop on theLinkedList
and having a manual counter for the index as it is needed elsewhere.The text was updated successfully, but these errors were encountered: