solve issue #2039 (DOM readIntSavableMap() doesn't check exceptions) #2052
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephengold
changed the title
| ret.put(key, val); | ||
| }catch (NumberFormatException nfe) { | ||
| IOException io = new IOException(nfe.toString()); | ||
| io.initCause(nfe); |
There was a problem hiding this comment.
I don't think it's a good idea to throw a checked exception from an unchecked exception, if you want to propagate an unchecked runtime exception to the user application use a throws NumberFormatException in the method declaration to give a clue to catch the exception or else use a strategy pattern with a compatible JDK interface to handle this exception from the user application, but this shouldn't throw a business checked exception.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Integer.parseInt(currentElem.getAttribute("key")) can throw NumberFormatException, which is inconsistent with other parsing methods.