Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid type of a target field should only be deleted where necessary #4

Open
aseeland opened this issue Apr 26, 2023 · 0 comments
Open

Comments

@aseeland
Copy link
Contributor

The check_value function of https://github.com/izus-fokus/metadata2dataverse/blob/main/v1/models/Field.py accepts arrays and return false when one element does not match the correct type.

This ist too strong - it should just remove individual values in an array, that have an incorrect type.

It is also unclear what this lines do:

if '\n' in value:
value.replace('\n', ' ')

since value is not returned in the function. Does this manipulate the array by reference? Then one can introduce 'none' for elements that do not have a correct type.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant