Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The highlight function de-highlights the same properties #2733

Closed
Tautvis88 opened this issue Apr 29, 2024 · 6 comments
Closed

The highlight function de-highlights the same properties #2733

Tautvis88 opened this issue Apr 29, 2024 · 6 comments
Labels

Comments

@Tautvis88
Copy link

Tautvis88 commented Apr 29, 2024

Have you checked the issues and discussions to ensure there are no duplicates?

No

Your programming languages

JavaScript, Typescript

Free or paid?

Paid users

Expected Behavior

image

Current Behavior

image

Code snippet for reproduce

  describe('case with locked fields', () => {
    beforeEach(() => {
      setBaseData();

      component.onCampaignDetailsChange(
        hirePurchaseForm.group<CreditSubsidyFormGroup>({
          [CreditFormFields.IsSubsidyActivated]: hirePurchaseForm.nonNullable.control(false),
          [CreditFormFields.SubsidizedBy]: hirePurchaseForm.nonNullable.control(undefined),
          [CreditFormFields.SubsidyDuration]: hirePurchaseForm.nonNullable.control(undefined),
          [CreditFormFields.SubsidizedValue]: hirePurchaseForm.nonNullable.control('0'),
        })
      );
      component.onPaymentDetailsChange(
        hirePurchaseForm.nonNullable.group<CreditPaymentFormGroup>({
          [CreditFormFields.PaymentModel]: hirePurchaseForm.nonNullable.control(paymentModelArrears.value),
          [CreditFormFields.PaymentPeriod]: hirePurchaseForm.nonNullable.control(paymentDetailsInit.paymentPeriod),
          [CreditFormFields.DirectDebit]: hirePurchaseForm.nonNullable.control(paymentDetailsInit.directDebit),
          [CreditFormFields.PlanStartDate]: hirePurchaseForm.nonNullable.control(paymentDetailsInit.planStartDate),
          [CreditFormFields.ContractNumber]: hirePurchaseForm.nonNullable.control('123'),
        })
      );
      component.onInterestDetailsChange(
        hirePurchaseForm.nonNullable.group<CreditInterestFormGroup>({
          [CreditFormFields.Rate]: hirePurchaseForm.nonNullable.control('10'),
          [CreditFormFields.RateType]: hirePurchaseForm.nonNullable.control(interestDetailsInit.rateType),
          [CreditFormFields.Date]: hirePurchaseForm.nonNullable.control(interestDetailsInit.date),
          [CreditFormFields.Period]: hirePurchaseForm.nonNullable.control(interestDetailsInit.period),
        })
      );
    });
 }

Your Environment

WebStorm 2024.1.2
Build #WS-241.15989.105, built on April 23, 2024

Runtime version: 17.0.10+1-b1207.14 amd64
VM: OpenJDK 64-Bit Server VM by JetBrains s.r.o.
Windows 10.0
GC: G1 Young Generation, G1 Old Generation
Memory: 8192M
Cores: 8
Registry:
ide.experimental.ui=true
terminal.new.ui=true
ide.check.windows.defender.rules=false
Non-Bundled Plugins:
de.espend.idea.localization (0.0.6)
com.jetbrains.edu (2024.4-2024.1-742)
com.intellij.properties (241.14494.150)
XPathView (241.15989.65)
com.intellij.ml.llm (241.15989.102)
me.mbolotov.cypress (1.6.2)
zielu.gittoolbox (500.2.6+233)
dev.nx.console (1.21.0)
izhangzhihao.rainbow.brackets (2024.2.3-241)

@Tautvis88 Tautvis88 added the bug? label Apr 29, 2024
@izhangzhihao

This comment was marked as outdated.

@Tautvis88
Copy link
Author

Tautvis88 commented Apr 30, 2024 via email

@izhangzhihao
Copy link
Owner

I see, but if you are using the Highlight option, which means you may accept that current highlighting will be overwritten right? And BTW, the IntelliJ platform does not support highlighting co-existing with prev existing highlighting at the same time, which means the first highlighting will be overwritten by the last one.

@izhangzhihao izhangzhihao removed the bug? label Apr 30, 2024
@Tautvis88
Copy link
Author

Tautvis88 commented Apr 30, 2024 via email

@izhangzhihao
Copy link
Owner

izhangzhihao commented Apr 30, 2024

Maybe the Border option is suitable for you?

also, link this issue to #2644 since this may help users understand how it works.

@Tautvis88
Copy link
Author

Tautvis88 commented Apr 30, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants