Skip to content

Commit a27fa78

Browse files
committed
qax-os#1402 Get CountRows from sheet
add close file and benchmark
1 parent ea542a0 commit a27fa78

File tree

1 file changed

+26
-0
lines changed

1 file changed

+26
-0
lines changed

rows_test.go

Lines changed: 26 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1156,6 +1156,7 @@ func TestFile_CountRows(t *testing.T) {
11561156
t.Run(tt.name, func(t *testing.T) {
11571157
f, err := OpenFile(tt.fields.filename)
11581158
assert.NoError(t, err)
1159+
defer f.Close()
11591160
firstSheet := f.GetSheetName(0)
11601161
got, err := f.CountRows(firstSheet)
11611162
if !tt.wantErr(t, err, "CountRows") {
@@ -1165,3 +1166,28 @@ func TestFile_CountRows(t *testing.T) {
11651166
})
11661167
}
11671168
}
1169+
1170+
func BenchmarkFile_GetRows_Old(b *testing.B) {
1171+
for i := 0; i < b.N; i++ {
1172+
f, _ := OpenFile(filepath.Join("test", "Book1.xlsx"))
1173+
defer f.Close()
1174+
1175+
firstSheet := f.GetSheetName(0)
1176+
count := 0
1177+
rows, _ := f.GetRows(firstSheet)
1178+
for range rows {
1179+
count++
1180+
}
1181+
}
1182+
}
1183+
1184+
func BenchmarkFile_GetRows_New(b *testing.B) {
1185+
for i := 0; i < b.N; i++ {
1186+
f, _ := OpenFile(filepath.Join("test", "Book1.xlsx"))
1187+
defer f.Close()
1188+
1189+
firstSheet := f.GetSheetName(0)
1190+
_, err := f.CountRows(firstSheet)
1191+
assert.NoError(b, err)
1192+
}
1193+
}

0 commit comments

Comments
 (0)