Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Username check seems to fail #10

Open
mariusvw opened this issue Apr 16, 2020 · 1 comment
Open

Username check seems to fail #10

mariusvw opened this issue Apr 16, 2020 · 1 comment

Comments

@mariusvw
Copy link

When loading a project with project manager it seems the check happens a bit to early.
The user.username is set, still it asks for it. When I cancel the message the plugin won't be asking it again, if I restart vscode with the same open project it sometimes asks for the name and sometimes does not.

Message in vscode:

Config Variable 'user.username' not set. Please enter a value (Press 'Enter' to confirm or 'Escape' to cancel)

Suspicious code part:

https://github.com/ivanhofer/git-assistant/blob/3bfdbd55b32b1da65fcdd70c134976a6782a3de8/src/handlers/start/CheckConfigVariables.handler.ts#L29
@ivanhofer
Copy link
Owner

What do you mean with "project manager"?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants