-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Compilations feature #4032
base: master
Are you sure you want to change the base?
Compilations feature #4032
Conversation
Make sure to run Mmh this requires database changes, I guess this won't be able to get merged anytime soon. Explained here: #2254 (comment) Note: this includes typo fixes and "utils" minor changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you revert the changes where you remove the newline at the end of a file? It's unnecessary thank you.
I see that on many files.
Additional questions:
|
This comment was marked as resolved.
This comment was marked as resolved.
Regarding JavaScript, I'm unsure - but will address this right after IE 11 |
I finished testing and determined JavaScript-less and IE 11 functionality are out-of-scope for this PR Explanation: My feature is contingent on the ability to start a video after timestamp (All good and no disrespect meant! I believe the fact that invidious already allow basic functionality on JavaScript-less environments or IE 11 is more than apt for the accessibility cause - glad the maintainers care!) |
I'm curious, is there a reason why compilations are separate from playlists? I feel like this feature might be easier to maintain if it updated playlists to allow specifying start and end times for playlist videos instead of creating new tables and views for compilations. |
True and maybe this way it would have probably necessitate no schema change in the database (no migrations to do probably). |
@ChunkyProgrammer Why don't you visit 000136.xyz (@unixfox add this to public invidious list - it's been a month-thanks!) and see for yourself? If you are sold on the idea, fork my fork and simplify it yourself :) |
It would also allow you to consider #4359 |
Addresses #3857
To try this out, pull the fork/branch
compilation_video
, adjust the starting timestamp and the ending timestamp, either or none (using legal or illegal arguments)