Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature request] Make it easier to configure a custom npm registry base URL. #4360

Closed
mk-pmb opened this issue Dec 29, 2023 · 2 comments
Closed
Labels
feature-request Request of a new feature

Comments

@mk-pmb
Copy link

mk-pmb commented Dec 29, 2023

Is your feature request related to a problem? Please describe.
In my network setup, the docker container cannot directly download from https://registry.npmjs.org/ , so I'd like to configure my own npm registry URL pointing to a local mirror.

Describe the solution you'd like
Maybe a docker build arg or something.

Describe alternatives you've considered
Changing the hard-coded URL in fetch-player-dependencies.cr line 86

Additional context

@mk-pmb mk-pmb added the feature-request Request of a new feature label Dec 29, 2023
@mk-pmb
Copy link
Author

mk-pmb commented Dec 29, 2023

Actually, I have an even better idea. (#4361) I'll leave this around closed to help other people find it who had the same initial approach.

@unixfox
Copy link
Member

unixfox commented Dec 29, 2023

Feel free to submit a PR for being able to configure the npm registry URL.

There is an example here for using crystal flags:

{% skip_file if flag?(:api_only) %}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request Request of a new feature
Projects
None yet
Development

No branches or pull requests

2 participants