JS: Update timeupdate event defensive to prevent errors (#4782)

iv-org · Feb 26, 2025 · d0433c8 · d0433c8
2 parents 4ea4878 + 7214fda
commit d0433c8
Showing 1 changed file with 18 additions and 12 deletions.
diff --git a/assets/js/player.js b/assets/js/player.js
@@ -134,26 +134,32 @@ player.on('timeupdate', function () {
     // YouTube links
 
     let elem_yt_watch = document.getElementById('link-yt-watch');
+    if (elem_yt_watch) {
+        let base_url_yt_watch = elem_yt_watch.getAttribute('data-base-url');
+        elem_yt_watch.href = addCurrentTimeToURL(base_url_yt_watch);
+    }
+
     let elem_yt_embed = document.getElementById('link-yt-embed');
-
-    let base_url_yt_watch = elem_yt_watch.getAttribute('data-base-url');
-    let base_url_yt_embed = elem_yt_embed.getAttribute('data-base-url');
-
-    elem_yt_watch.href = addCurrentTimeToURL(base_url_yt_watch);
-    elem_yt_embed.href = addCurrentTimeToURL(base_url_yt_embed);
+    if (elem_yt_embed) {
+        let base_url_yt_embed = elem_yt_embed.getAttribute('data-base-url');
+        elem_yt_embed.href = addCurrentTimeToURL(base_url_yt_embed);
+    }
 
     // Invidious links
 
     let domain = window.location.origin;
 
     let elem_iv_embed = document.getElementById('link-iv-embed');
+    if (elem_iv_embed) {
+        let base_url_iv_embed = elem_iv_embed.getAttribute('data-base-url');
+        elem_iv_embed.href = addCurrentTimeToURL(base_url_iv_embed, domain);
+    }
+
     let elem_iv_other = document.getElementById('link-iv-other');
-
-    let base_url_iv_embed = elem_iv_embed.getAttribute('data-base-url');
-    let base_url_iv_other = elem_iv_other.getAttribute('data-base-url');
-
-    elem_iv_embed.href = addCurrentTimeToURL(base_url_iv_embed, domain);
-    elem_iv_other.href = addCurrentTimeToURL(base_url_iv_other, domain);
+    if (elem_iv_other) {
+        let base_url_iv_other = elem_iv_other.getAttribute('data-base-url');
+        elem_iv_other.href = addCurrentTimeToURL(base_url_iv_other, domain);
+    }
 });