Go benchmark test and fixed --cpu-profile option (deepnoodle-ai#257)

Author: myzie

.gitignore

@@ -1,3 +1,5 @@
+/risor
+/tmp*
 .vscode
 node_modules
 

Makefile

@@ -8,12 +8,16 @@ test:
 	gotestsum --junitfile /tmp/test-reports/unit-tests.xml \
 		-- -coverprofile=coverage.out -covermode=atomic ./... ./cmd/risor/...
 
-.PHONY: bench
-bench:
+.PHONY: pprof
+pprof:
 	go build
-	./risor -profile cpu.out ./benchmark/main.mon
+	./risor --cpu-profile cpu.out ./examples/scripts/fibonacci.risor
 	go tool pprof -http=:8080 ./cpu.out
 
+.PHONY: bench
+bench:
+	go test -bench=. -benchmem ./bench
+
 # https://code.visualstudio.com/api/working-with-extensions/publishing-extension#packaging-extensions
 .PHONY: install-tools
 install-tools:

README.md

@@ -206,6 +206,15 @@ is already available which currently only offers syntax highlighting.
 
 You can also make use of the [Risor TextMate grammar](./vscode/syntaxes/risor.grammar.json).
 
+## Benchmarking
+
+There are two Makefile commands that assist with benchmarking and CPU profiling:
+
+```
+make bench
+make pprof
+```
+
 ## Contributing
 
 Risor is intended to be a community project. You can lend a hand in various ways:

bench/bench_test.go

@@ -0,0 +1,46 @@
+package risor_test
+
+import (
+	"context"
+	"log"
+	"testing"
+
+	"github.com/risor-io/risor/compiler"
+	"github.com/risor-io/risor/parser"
+	"github.com/risor-io/risor/vm"
+)
+
+func BenchmarkRisor_Fibonacci35(b *testing.B) {
+	script := `
+    func fibonacci(n) {
+        if n <= 1 {
+            return n
+        }
+        return fibonacci(n-1) + fibonacci(n-2)
+    }
+    fibonacci(35)
+    `
+
+	ctx := context.Background()
+
+	ast, err := parser.Parse(ctx, script)
+	if err != nil {
+		log.Fatal(err)
+	}
+
+	code, err := compiler.Compile(ast)
+	if err != nil {
+		log.Fatal(err)
+	}
+
+	b.ResetTimer()
+	for i := 0; i < b.N; i++ {
+		result, err := vm.Run(ctx, code)
+		if err != nil {
+			b.Fatal(err)
+		}
+		if result.Interface().(int64) != 9227465 {
+			b.Fatalf("unexpected result: %v", result)
+		}
+	}
+}

cmd/risor/root.go

@@ -5,6 +5,7 @@ import (
 	"fmt"
 	"os"
 	"path/filepath"
+	"runtime/pprof"
 	"strings"
 	"time"
 
@@ -132,6 +133,16 @@ var rootCmd = &cobra.Command{
 		ctx := context.Background()
 		processGlobalFlags()
 
+		if path := viper.GetString("cpu-profile"); path != "" {
+			f, err := os.Create(path)
+			if err != nil {
+				fatal(err)
+			}
+			pprof.StartCPUProfile(f)
+			defer pprof.StopCPUProfile()
+			handleSigForProfiler()
+		}
+
 		// Separate arguments belonging to the Risor CLI from those that are
 		// to be passed to the script.
 		var scriptArgs []string

cmd/risor/util.go

@@ -173,13 +173,4 @@ func processGlobalFlags() {
 	if viper.GetBool("no-color") {
 		color.NoColor = true
 	}
-	if path := viper.GetString("cpu-profile"); path != "" {
-		f, err := os.Create(path)
-		if err != nil {
-			fatal(err)
-		}
-		pprof.StartCPUProfile(f)
-		defer pprof.StopCPUProfile()
-		handleSigForProfiler()
-	}
 }

examples/scripts/fibonacci.risor

@@ -0,0 +1,9 @@
+
+func fibonacci(n) {
+    if n <= 1 {
+        return n
+    }
+    return fibonacci(n-1) + fibonacci(n-2)
+}
+
+fibonacci(35)