Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

codecov: lightning coverage wrongly reported as 0 #666

Open
daavoo opened this issue Aug 16, 2023 · 2 comments
Open

codecov: lightning coverage wrongly reported as 0 #666

daavoo opened this issue Aug 16, 2023 · 2 comments
Labels
bug Did we break something? maintenance p2-medium

Comments

@daavoo
Copy link
Contributor

daavoo commented Aug 16, 2023

For some reason, codecov is reporting the lightning integration as 0% coverage, even though there is https://github.com/iterative/dvclive/blob/main/tests/test_frameworks/test_lightning.py .

I suspect this is related to the hacks we do in the imports to support different versions

@daavoo daavoo added bug Did we break something? maintenance labels Aug 16, 2023
@daavoo daavoo changed the title codecov: lightning coverage wrongly reported as 0. codecov: lightning coverage wrongly reported as 0 Aug 16, 2023
@dberenbaum dberenbaum added the p1-important Include in the next sprint label Oct 11, 2023
@natikgadzhi
Copy link
Contributor

Report: https://app.codecov.io/gh/iterative/dvclive/blob/main/tests%2Fframeworks%2Ftest_lightning.py

Interestingly, it's the test file itself that codecov thinks is not covered.

The actual lightning framework coverage is fine: https://app.codecov.io/gh/iterative/dvclive/tree/main/src%2Fdvclive.

Should we perhaps just ignore the test_lightning.py in codecov.yml?

@dberenbaum
Copy link
Collaborator

dberenbaum commented Nov 30, 2023

Any idea why it is only an issue for that test file and none of the others?

Actually, I'm not seeing the same. I see 0% coverage in https://app.codecov.io/gh/iterative/dvclive/blob/main/src%2Fdvclive%2Flightning.py. Am I misreading it?

Screenshot 2023-11-30 at 1 22 52 PM

@dberenbaum dberenbaum added p2-medium and removed p1-important Include in the next sprint labels Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Did we break something? maintenance p2-medium
Projects
None yet
Development

No branches or pull requests

3 participants