-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
codecov: lightning
coverage wrongly reported as 0
#666
Comments
lightning
coverage wrongly reported as 0.lightning
coverage wrongly reported as 0
Report: https://app.codecov.io/gh/iterative/dvclive/blob/main/tests%2Fframeworks%2Ftest_lightning.py Interestingly, it's the test file itself that codecov thinks is not covered. The actual lightning framework coverage is fine: https://app.codecov.io/gh/iterative/dvclive/tree/main/src%2Fdvclive. Should we perhaps just ignore the |
Actually, I'm not seeing the same. I see 0% coverage in https://app.codecov.io/gh/iterative/dvclive/blob/main/src%2Fdvclive%2Flightning.py. Am I misreading it? |
For some reason,
codecov
is reporting the lightning integration as 0% coverage, even though there is https://github.com/iterative/dvclive/blob/main/tests/test_frameworks/test_lightning.py .I suspect this is related to the hacks we do in the imports to support different versions
The text was updated successfully, but these errors were encountered: