Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

integrations: ultralytics/yolo #603

Open
dberenbaum opened this issue Jun 21, 2023 · 7 comments · Fixed by #650
Open

integrations: ultralytics/yolo #603

dberenbaum opened this issue Jun 21, 2023 · 7 comments · Fixed by #650
Labels
A: frameworks Area: ML Framework integration p3-nice-to-have

Comments

@dberenbaum
Copy link
Collaborator

Need to document the yolo callback from https://github.com/ultralytics/ultralytics/blob/main/ultralytics/yolo/utils/callbacks/dvc.py into dvclive and utralytics docs.

@dberenbaum dberenbaum added the p1-important Include in the next sprint label Jun 21, 2023
@shcheklein
Copy link
Member

Ultralytics generates their docs for all the callbacks I think? Or do you want to add a more comprehensive overview, etc? I was thinking about this, but I don't feel we are ready for that. I don't know how to use the callback in the real project yet. (specifically, what do with images folder, how to combine it with the existing dvc.yaml, etc)- I felt we need some time to address those (or agree that those are not important / we have a good workaround).

@daavoo
Copy link
Contributor

daavoo commented Jun 22, 2023

Ultralytics generates their docs for all the callbacks I think?

This is the only thing rendered, which is not very helpful I guess https://docs.ultralytics.com/reference/yolo/utils/callbacks/dvc/
Can we add some docstrings?

Or do you want to add a more comprehensive overview, etc?

I think we could start by adding a page to our docs https://dvc.org/doc/dvclive/ml-frameworks with minimum explanation on how to use it.

There is also this in the ultralytics docs: https://docs.ultralytics.com/modes/train/#logging but TBH I don't really understand the page (Maybe it is me but I haven't figured out yet how to set up / use any logger just form the docs)

I was thinking about this, but I don't feel we are ready for that. I don't know how to use the callback in the real project yet. (specifically, what do with images folder, how to combine it with the existing dvc.yaml, etc)- I felt we need some time to address those (or agree that those are not important / we have a good workaround).

I was also planning to try to use it in a project myself and see what is going on.
Also, I see that images can be valuable but can we start by not using them? Other loggers don't do anything with them and I think it is ok to start with metrics and linear plots while we figure this other things

@dberenbaum
Copy link
Collaborator Author

For comparison: https://docs.wandb.ai/guides/integrations/yolov5

@shcheklein
Copy link
Member

Also, I see that images can be valuable but can we start by not using them? Other loggers don't do anything with them and I think it is ok to start with metrics and linear plots while we figure this other things

All loggers actually do log them, and support per step navigation.

I think we could start by adding a page to our docs https://dvc.org/doc/dvclive/ml-frameworks with minimum explanation on how to use it.

Yes, I can start on that.

@shcheklein
Copy link
Member

I think it's not done, right? We still don't have docs / guide on the YOLO side, let's keep it open for now?

@shcheklein shcheklein reopened this Aug 4, 2023
@shcheklein
Copy link
Member

Relevant ultralytics/ultralytics#4343 (comment)

@daavoo
Copy link
Contributor

daavoo commented Sep 5, 2023

Lowering to p2, as we have a decent enough integration and docs in what we can control (dvc.org), not sure what is left beyond docs/guide on YOLO side

@daavoo daavoo added p2-medium and removed p1-important Include in the next sprint labels Sep 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A: frameworks Area: ML Framework integration p3-nice-to-have
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants