Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: don't override --global git user.{name,email} when running locally #1331

Open
casperdcl opened this issue Jan 31, 2023 · 1 comment
Open

ci: don't override --global git user.{name,email} when running locally #1331

casperdcl opened this issue Jan 31, 2023 · 1 comment
Labels
cml-ci Subcommand enhancement New feature or request p2-nice-to-have Low priority technical-debt Refactoring, linting & tidying

Comments

@casperdcl
Copy link
Contributor

Debugging CML locally often leads to overriding git config --global user.{name,email}.

cml ci should probably not do this if the detected driver is null (local).
@casperdcl casperdcl added enhancement New feature or request technical-debt Refactoring, linting & tidying p2-nice-to-have Low priority cml-ci Subcommand labels Jan 31, 2023
@casperdcl casperdcl changed the title ci: don't override --global git user.{name,email} ci: don't override --global git user.{name,email} when running locally Jan 31, 2023
@dacbd
Copy link
Contributor

dacbd commented Feb 10, 2023

should we check for existing values instead?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
cml-ci Subcommand enhancement New feature or request p2-nice-to-have Low priority technical-debt Refactoring, linting & tidying
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dacbd @casperdcl