Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

commit create #1308

Closed
casperdcl opened this issue Jan 11, 2023 · 3 comments
Closed

commit create #1308

casperdcl opened this issue Jan 11, 2023 · 3 comments
Labels
cml-new New subcommand request discussion Waiting for team decision

Comments

@casperdcl
Copy link
Contributor

With similar convenience options as cml pr create.

cml commit create [--skip-ci] [--message=<...>] [--user-<name|email>=<...>]

Example use case:

cml ci
git commit -a -m "CML commit [skip ci]"
while ! git push; do
  git fetch origin $BRANCH
  git rebase origin/$BRANCH
done

to push a new commit without infinite CI recursion or overwriting simultaneous pushes

@casperdcl casperdcl added the cml-new New subcommand request label Jan 11, 2023
@0x2b3bfa0
Copy link
Member

0x2b3bfa0 commented Jan 17, 2023

How is this better or more reliable than pull requests? It looks like discord#cml/1062574117179641946 could be solved with cml pr create --squash instead of this. 🤔

@casperdcl
Copy link
Contributor Author

casperdcl commented Jan 26, 2023

Because a PR is more heavyweight/overkill, and also might have some undesirable side-effects (trigger different workflows).

@casperdcl casperdcl added the discussion Waiting for team decision label Jan 26, 2023
@0x2b3bfa0
Copy link
Member

It's indeed a bit more heavyweight, but also more idiomatic: otherwise we'd be reinventing automatic conflict resolution.

@0x2b3bfa0 0x2b3bfa0 closed this as not planned Won't fix, can't repro, duplicate, stale May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cml-new New subcommand request discussion Waiting for team decision
Projects
None yet
Development

No branches or pull requests

2 participants