Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The validator should be stricter with language codes #47

Open
bfabio opened this issue Aug 18, 2020 · 1 comment
Open

The validator should be stricter with language codes #47

bfabio opened this issue Aug 18, 2020 · 1 comment
Labels
bug Something isn't working Hacktoberfest help wanted Extra attention is needed

Comments

@bfabio
Copy link
Member

bfabio commented Aug 18, 2020

checkLanguageCode should be stricter and check for valid BCP47 tags only, as defined in the standard
@bfabio bfabio changed the title The validator should be stricter with langaguage codes The validator should be stricter with language codes Aug 18, 2020
@bfabio bfabio mentioned this issue Aug 18, 2020
Merged
@bfabio bfabio added this to the 2.0.0 milestone Feb 7, 2021
bfabio added a commit to bfabio/publiccode-parser-go that referenced this issue Mar 23, 2022
@bfabio
test: add disabled test for BCP47 tag
fdac346 
Related to italia#47.
bfabio added a commit to bfabio/publiccode-parser-go that referenced this issue Mar 23, 2022
@bfabio
test: add disabled test for BCP47 tag
f1fe87f 
Go's language.Parse() is more lenient and allows non-BCP47 language
tags. Let's add a disabled test for now.

Related to italia#47.
@bfabio bfabio mentioned this issue Mar 23, 2022
Merged
@bfabio
Copy link
Member Author

bfabio commented Mar 23, 2022 •
edited
Loading

Go's language.Parse() is lenient and allows non-BCP47 language tags, this probably means we need to switch the parsing library altogether to a stricter one, which I don't know if it exists.

Putting on hold for now.

@bfabio bfabio added the bug Something isn't working label Mar 23, 2022
bfabio added a commit to bfabio/publiccode-parser-go that referenced this issue Mar 23, 2022
@bfabio
test: add disabled test for BCP47 tag
5d8de67 
Go's language.Parse() is more lenient and allows non-BCP47 language
tags. Let's add a disabled test for now.

Related to italia#47.
@bfabio bfabio removed this from the 2.0.0 milestone Mar 30, 2022
@bfabio bfabio added the help wanted Extra attention is needed label Apr 28, 2022
bfabio added a commit to bfabio/publiccode-parser-go that referenced this issue Feb 18, 2023
@bfabio
test: add disabled test for BCP47 tag
6ebde13 
Go's language.Parse() is more lenient and allows non-BCP47 language
tags. Let's add a disabled test for now.

Related to italia#47.
bfabio added a commit to bfabio/publiccode-parser-go that referenced this issue Jul 20, 2024
@bfabio
test: "eng" is not a valid BCP language
59db8e8 
Change the tests so there's no invalid BCP "eng" language.

We don't catch that as an error yet because of italia#47.
@bfabio bfabio mentioned this issue Jul 20, 2024
Merged
bfabio added a commit that referenced this issue Jul 20, 2024
@bfabio
test: "eng" is not a valid BCP language (#199)
e721d95 
Change the tests so there's no invalid BCP "eng" language.

We don't catch that as an error yet because of #47.
@bfabio bfabio mentioned this issue Dec 7, 2024
Open
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working Hacktoberfest help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@bfabio