Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Alignments of Data Model Section with SD-JWT and SD-JWT-VC latest drafts #511

Open
wants to merge 11 commits into
base: versione-corrente
Choose a base branch
from
Open

Alignments of Data Model Section with SD-JWT and SD-JWT-VC latest drafts #511

wants to merge 11 commits into from

Conversation

m-basili
Copy link
Collaborator

@m-basili m-basili commented Dec 2, 2024

This PR:

List changes introduced:

  • Renamed typ value from vc+sd-jwt to dc+sd-jwt
  • Renamed credential metadata claim schema#integrity to schema_uri#integrity
  • Introduced credential metadata claims display and claims as a replacement for vc_claims
  • Added to data_source credential metadata the following claims: homepage_uri, contacs and logo_uri
  • Renamed PID claim tax_id_code to personal_administrative_number
  • fix typos and links
  • Updated non-normative examples
  • Updated normative references

@m-basili m-basili added this to the 0.9.0 milestone Dec 2, 2024
@m-basili
Copy link
Collaborator Author

Removed also unique_id attribute.

@m-basili m-basili requested a review from peppelinux December 11, 2024 10:10
giadas
giadas approved these changes Dec 18, 2024
View reviewed changes
Copy link
Collaborator

@giadas giadas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tax_id_code and unique_id are still present in non normative examples of the following sections:

  • Entity Configuration of PID/(Q)EAA Providers
  • Entity Configuration of Relying Parties
  • PID/(Q)EAA Data Model (in the mdoc example)
  • Relying Party Solution

@m-basili
Copy link
Collaborator Author

Removed unique_id and tax_id_code from the non-normative examples reported by @giadas.

@m-basili m-basili requested a review from giadas December 18, 2024 11:02
@m-basili
Copy link
Collaborator Author

This last commit 3fd8d1a resolves #510.

giadas
giadas reviewed Dec 18, 2024
View reviewed changes
docs/en/pid-eaa-data-model.rst
* ``evidence``: It MUST contain ``method`` claim identifying the digital identity system used for the authentication.
- [SD]. Object containing user authentication and user data verification information. It is REQUIRED only if the Credential type is PersonIdentificationData, and it MUST not be included in other Credential types. It MUST include the following sub-value:

* ``assurance_level``: String identifying the level of identity assurance guaranteed during the User authentication process.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not clear, considering the PersonIdentificationData, are there cases where the identity assurance level during the User authentication process is not high?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@giadas giadas giadas approved these changes

@grausof grausof Awaiting requested review from grausof

@fmarino-ipzs fmarino-ipzs Awaiting requested review from fmarino-ipzs

@peppelinux peppelinux Awaiting requested review from peppelinux

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
specification alignment
Projects
EUDI Wallet IT Technical Specifications
Status: No status
Milestone
0.9.0
3 participants
@m-basili @peppelinux @giadas