Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Proxy images instead of linking to the repo's URL #1246

Open
ruphy opened this issue Feb 14, 2022 · 0 comments · May be fixed by #1497
Open

Proxy images instead of linking to the repo's URL #1246

ruphy opened this issue Feb 14, 2022 · 0 comments · May be fixed by #1497

Comments

@ruphy
Copy link
Member

ruphy commented Feb 14, 2022

Some code hosting platforms (e.g. invent.kde.org) are not meant to serve images. Our current backend is more strict than it should, requiring that images are inside the repository, instead of accepting any URL as valid (as per standard).

Desired behiavor: We should accept any URL and allow software vendors to use any URL for their images, in the case they have a CDN or prefer to host their screenshots or other material on a different service.
@bfabio bfabio transferred this issue from italia/publiccode-crawler Jun 22, 2022
@bfabio bfabio mentioned this issue Nov 1, 2023
Closed
bfabio added a commit to bfabio/developers.italia.it that referenced this issue Jul 30, 2024
@bfabio
wip: use proxied image assets
e62ffee 
https://github.com/italia/assets.developers.italia.it

Fix italia#1246.
@bfabio bfabio linked a pull request Jul 30, 2024 that will close this issue
Draft
bfabio added a commit to bfabio/developers.italia.it that referenced this issue Jul 30, 2024
@bfabio
wip: use proxied image assets
9594fec 
https://github.com/italia/assets.developers.italia.it

Fix italia#1246.
bfabio added a commit to bfabio/developers.italia.it that referenced this issue Aug 1, 2024
@bfabio
wip: use proxied image assets
db4f557 
https://github.com/italia/assets.developers.italia.it

Fix italia#1246.
bfabio added a commit to bfabio/developers.italia.it that referenced this issue Aug 1, 2024
@bfabio
wip: use proxied image assets
ae66309 
https://github.com/italia/assets.developers.italia.it

Fix italia#1246.
bfabio added a commit to bfabio/developers.italia.it that referenced this issue Aug 1, 2024
@bfabio
wip: use proxied image assets
49d0a63 
https://github.com/italia/assets.developers.italia.it

Fix italia#1246.
bfabio added a commit to bfabio/developers.italia.it that referenced this issue Aug 1, 2024
@bfabio
wip: use proxied image assets
ab1658d 
https://github.com/italia/assets.developers.italia.it

Fix italia#1246.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

wip: use proxied image assets bfabio/developers.italia.it
1 participant
@ruphy