Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The examples from Bootstrap Italia API do not show icons. #1142

Open
1 task done
Fupete opened this issue Dec 15, 2023 · 3 comments
Open
1 task done

The examples from Bootstrap Italia API do not show icons. #1142

Fupete opened this issue Dec 15, 2023 · 3 comments
Assignees
@astagi
Labels
bug dependencies Pull requests that update a dependency file design system

Comments

@Fupete
Copy link
Collaborator

Fupete commented Dec 15, 2023

Does a discussion already exist on the topic you are interested in, or on a similar topic?

  • I verified and it doesn't exist

What

See comparison. Tab with icon.
Left Documentation of the design system. Right Documentation of Bootstrap Italia.
immagine

On the left the svg/use has href="/bootstrap-italia/dist/svg/sprites.svg#en-file and our website has /dist/svg/sprites.svg#en-file.

Did something change with one of the latest versions of Bootstrap Italia? Or did we do something? 🤔 Could it be related to #1122?

@astagi @bfabio

Why

🔴 all the icons are gone, in all the DS examples...

Context

No response

More

No response
@Fupete Fupete added bug dependencies Pull requests that update a dependency file design system labels Dec 15, 2023
@Fupete Fupete moved this to ✏ Todo in Designers Italia - Website Dec 15, 2023
@Fupete Fupete mentioned this issue Dec 15, 2023
Closed
1 task
@Fupete
Copy link
Collaborator Author

Fupete commented Dec 15, 2023

I think we inserted the bug here https://github.com/italia/designers.italia.it/pull/907/files @bfabio @astagi
immagine

Let's fix it ASAP.

@astagi astagi linked a pull request Dec 15, 2023 that will close this issue
chore(deps): update Bootstrap Italia and DS examples #1137
Merged
@Fupete Fupete removed a link to a pull request Dec 15, 2023
chore(deps): update Bootstrap Italia and DS examples #1137
Merged
@Fupete
Copy link
Collaborator Author

Fupete commented Dec 15, 2023

Update. This newly merged #1137 will fix (revert) the bug entered on November 15. For example, see the Toolbar component.

But I just found that there are some components (e.g., Popover with icon) that still have the problem of not showing the icon. Perhaps this is another bug with the way we have been implementing BSI for a while now that we never discovered. We need to investigate more next week @astagi @bfabio .

@Fupete Fupete moved this from 🆕 New to 🏗 In progress in Design system .italia 🇮‍🇹 Dec 15, 2023
@Fupete Fupete moved this from ✏ Todo to 🛠 Doing in Designers Italia - Website Dec 15, 2023
@Fupete Fupete moved this from 🏗 In progress to 📋 Backlog in Design system .italia 🇮‍🇹 Dec 18, 2023
@Fupete Fupete modified the milestones: Design system: `v1` (2024 - Q2), Design system `v1+`(2024) Apr 5, 2024
@bfabio bfabio removed their assignment Jun 13, 2024
@Fupete
Copy link
Collaborator Author

Fupete commented Jul 1, 2024

@astagi fyi take a look

@Fupete Fupete removed their assignment Jul 1, 2024
@Fupete Fupete moved this from 🛠 Doing to ✏ Todo in Designers Italia - Website Jul 1, 2024
@Fupete Fupete mentioned this issue Aug 9, 2024
Closed
1 task
@Fupete Fupete removed this from the Design system `v1+`(2024) milestone Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@astagi astagi

Labels
bug dependencies Pull requests that update a dependency file design system
Projects
Design system .italia 🇮‍🇹
Status: 📋 Backlog
Designers Italia - Website
Status: ✏ Todo
Milestone
No milestone
Development

No branches or pull requests
3 participants
@astagi @bfabio @Fupete