Skip to content

Getting Started improvement #416

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
devtobi opened this issue Feb 13, 2025 · 0 comments
Open

Getting Started improvement #416

devtobi opened this issue Feb 13, 2025 · 0 comments
Labels
documentation Improvements or additions to documentation good first issue Good for newcomers

Comments

@devtobi
Copy link
Member

devtobi commented Feb 13, 2025

I have the following suggestions for the current getting started guide:

  1. Instead of integrating the external css file via ´style´-Tag, use the @import url() variant.
@import url("https://assets.muenchen.de/mde/1.0.7/css/muenchende-style.css");
@import "@muenchen/muc-patternlab-vue/assets/css/custom-style.css";
@import "@muenchen/muc-patternlab-vue/style.css";

I tested this and it keeps loading the css dynamically and does not increase the bundle size.

  1. Add additional information for the development setup in the context of using the library with web components:
<link
      href="https://assets.muenchen.de/mde/1.0.7/css/muenchende-fontfaces.css"
      rel="stylesheet"
/>

must be added to index.html to make sure the fonts are loaded when developing locally.

@devtobi devtobi added the documentation Improvements or additions to documentation label Feb 13, 2025
@FabianWilms FabianWilms added the good first issue Good for newcomers label Mar 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants