Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review and reduce ExcessiveClassLength threshold in PHPMD configuration #833

Open
coderabbitai bot opened this issue Feb 10, 2025 · 0 comments
Open
Assignees
Labels
code complexity and formatting Reduce code complexity or fix formatting php Pull requests that update Php code

Comments

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 10, 2025

The current PHPMD configuration in phpmd.rules.xml sets ExcessiveClassLength minimum threshold to 2000 lines, which is quite permissive and could lead to maintainability issues.

Consider reducing this value to improve code maintainability and encourage better class design through proper separation of concerns.

Current configuration:

<rule ref="rulesets/codesize.xml/ExcessiveClassLength">
    <properties>
        <property name="minimum" value="2000" />
    </properties>
</rule>

Context:

cc @ThomasAFink

@ThomasAFink ThomasAFink added code complexity and formatting Reduce code complexity or fix formatting php Pull requests that update Php code labels Feb 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code complexity and formatting Reduce code complexity or fix formatting php Pull requests that update Php code
Projects
None yet
Development

No branches or pull requests

1 participant