-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support providing per-workload proxy tasks with drain context #899
Comments
I do not see the drain-rs crate in the cargo.toml |
It's just called |
This was referenced Jun 25, 2024
I think this is mostly done and just 1 final task tracked in #1191 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Prompted by #898
What we really need beyond that PR with inpod is more granular drains than
ztunnel
is equipped with currently, at a minimum I can imagine the following:This is relatively easily accomplished with regular
tokio::sync
channels, we should probably just replace our use of https://github.com/linkerd/drain-rs (which is a very light wrapper around those) with use of the tokio sync primitives directly.ALSO - as part of this we should have draintests for EVERY handler.
inbound
outbound
inbound_passthrough
socks5
dns
that test that they are all guaranteed to drain down to 0 tasks when signaled.
The text was updated successfully, but these errors were encountered: