You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
We recently had an incident where a customer misread the output of istioctl proxy-config secret, which looks like this:
RESOURCE STATUS VALID NOT AFTER NOT BEFORE
ROOTCA ACTIVE true 2034-04-05T17:11:19Z 2024-04-07T17:11:19Z
ROOTCA ACTIVE true 2118-04-25T22:11:33Z 2018-04-25T21:11:33Z
Specifically, they thought that the date under NOT BEFORE was actually the NOT AFTER date.
Even though it's a little more natural to lay out the dates as "NOT BEFORE" first and "NOT AFTER" second, it is probably too late to do that because the command has had that format for 5 years and it people may depend on the format now.
Would it make the output more understandable if we renamed "NOT AFTER" to "VALID ON OR BEFORE" and "NOT BEFORE" to "VALID ON OR AFTER"? And if so, is it okay to make that change? cc @johnhoward
reacted with thumbs up emoji reacted with thumbs down emoji reacted with laugh emoji reacted with hooray emoji reacted with confused emoji reacted with heart emoji reacted with rocket emoji reacted with eyes emoji
-
We recently had an incident where a customer misread the output of
istioctl proxy-config secret
, which looks like this:Specifically, they thought that the date under NOT BEFORE was actually the NOT AFTER date.
Even though it's a little more natural to lay out the dates as "NOT BEFORE" first and "NOT AFTER" second, it is probably too late to do that because the command has had that format for 5 years and it people may depend on the format now.
Would it make the output more understandable if we renamed "NOT AFTER" to "VALID ON OR BEFORE" and "NOT BEFORE" to "VALID ON OR AFTER"? And if so, is it okay to make that change? cc @johnhoward
The headers are defined here:
istio/istioctl/pkg/writer/compare/sds/writer.go
Line 72 in f6a08fa
Beta Was this translation helpful? Give feedback.
All reactions