Replies: 1 comment
-
I had thought for sure this was how it works. Is that not the case? I recall we were using it for this purpose in a former deployment i worked on, but maybe we had some customization.. |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
I noticed we added a
defaultRevision
field way back in 2021 and it seems to make sure to point the ValidatingWebhook to that revision, which I think is cool when doing canary upgrades. It doesn't however affect injection - I would have expected that if I set thedefaultRevision
to a revision, it will allow me to use the istio-injection label again (instead of having to useistio.io/rev
), but that doesn't seem to be the case. Is there interest in that? If so, I'll implement itBeta Was this translation helpful? Give feedback.
All reactions