Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support more sorting type #45

Open
issadarkthing opened this issue Mar 16, 2021 · 3 comments
Open

Support more sorting type #45

issadarkthing opened this issue Mar 16, 2021 · 3 comments

Comments

@issadarkthing
Copy link
Owner

As of recent merged pr #41 where I mention we cannot directly access the creation time of file #41 (comment). I am still indecisive on we should use ctime or mtime as both have different behavior.

mtime changes if tag is changed but does not change if renamed
ctime changes if audio file is renamed but does not change if tag is changed

This leads me to add more sorting option to leave the decision up to the user. Few sort options I would like to implement are ctime, name and audio length.

Let me know which sorting options are redundant and irrelevant to the app itself. More sorting options suggestion are welcomed!

@tramhao
Copy link
Contributor

tramhao commented Mar 17, 2021

In my scenario, perhaps sorting by Tags could be an option too, like artist. Album nowadays are not so effective as most songs are singles.
And about the hot keys, could we do something like https://github.com/And678/goPlayer/blob/assets/screenshot.png, I mean showing some important keys as hint to users.

@issadarkthing
Copy link
Owner Author

In my scenario, perhaps sorting by Tags could be an option too, like artist. Album nowadays are not so effective as most songs are singles.

So the sorting options will be added are ctime, name, audio length and audio name tag.

And about the hot keys, could we do something like https://github.com/And678/goPlayer/blob/assets/screenshot.png, I mean showing some important keys as hint to users.

I can see this will be helpful for the beginner but I personally don't like it cluttering the screen. If we were to add this, maybe make it toggle-able in config file like show_hint = false.

@tramhao
Copy link
Contributor

tramhao commented Mar 17, 2021

I can see this will be helpful for the beginner but I personally don't like it cluttering the screen. If we were to add this, maybe make it toggle-able in config file like show_hint = false.

I agree with you. After a second thought, I think this is not very important as we already have very good help menu. And most keys are vim keys.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants