Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Authorization options on fetch/pull missing #1748

Open
on3iro opened this issue Mar 30, 2023 · 3 comments
Open

Authorization options on fetch/pull missing #1748

on3iro opened this issue Mar 30, 2023 · 3 comments

Comments

@on3iro
Copy link

on3iro commented Mar 30, 2023

Hey,

I am using isomorphic-git with Node and Typescript and just wanted to fetch from a private remote. However I noticed, that the API of fetch apparently does not reflect the documentation.
There are no username, token etc. properties inside the fetch-options object. (https://isomorphic-git.org/docs/en/fetch

Should one use onAuth instead or how is this supposed to work?

Thanks in advance

@jcubic
Copy link
Contributor

jcubic commented Mar 30, 2023

I'm not 100% sure but I think that username and password/token is an old API for isomorphic-git before 1.0 you should use onAuth as in documentation.

Where do you have information to use username and token?

@on3iro
Copy link
Author

on3iro commented Mar 30, 2023

@jcubic thanks for the quick response, using username and password comes from these docs: https://isomorphic-git.org/docs/en/authentication

The only deprecation regarding auth I could find inside the docs is this: https://isomorphic-git.org/docs/en/utils_auth - though that is an entirely different article.

@jcubic
Copy link
Contributor

jcubic commented Mar 30, 2023

I think that this page is outdated. This is what I'm using in my project but I use the library in the version 0.x.

There is no deprecation of any kind because versions before 1.0 can change at any time and version 1.0 beta was a huge change in comparison to version 0.x. At least this is what I think.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants