Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider moving isaqb-logo.jpg to html-theme #120

Open
aheusingfeld opened this issue Mar 29, 2022 · 1 comment
Open

Consider moving isaqb-logo.jpg to html-theme #120

aheusingfeld opened this issue Mar 29, 2022 · 1 comment
Labels
enhancement New feature or request

Comments

@aheusingfeld
Copy link
Member

aheusingfeld commented Mar 29, 2022 •
edited
Loading

I stumbled upon an inconsistency with the ISAQB logo.

  1. we seem to have it in 3 places
    1.1. https://github.com/isaqb-org/advanced-template/blob/main/docs/isaqb-logo.jpg
    1.2. https://github.com/isaqb-org/advanced-template/blob/main/docs/images/isaqb-logo.jpg
    1.3 within the pdf-theme submodule
    Due to :imagesdir: images in setup.adoc, the first one is actually not in use.

  2. As the pdf-theme contains its own version of isaqb-logo-without-text.jpg and isaqb-logo.jpg, wouldn't it make sense to do the same for html-theme?

  3. Bonus question: Did we try to switch the logo format to PNG?
@aheusingfeld aheusingfeld added enhancement New feature or request good first issue Good for newcomers labels Mar 29, 2022
@aheusingfeld aheusingfeld changed the title isaqb-logo.jpg is present twice Consider moving isaqb-logo.jpg to html-theme Mar 30, 2022
@aheusingfeld aheusingfeld removed the good first issue Good for newcomers label Mar 30, 2022
@programming-wolf
Copy link
Collaborator

programming-wolf commented May 30, 2022 •
edited
Loading

  1. Removed the first one in Remove redundant images #122
  2. html-theme currently does not use any logo, but it should for each curriculum (as pdf-theme does).
  3. No, why? I reduced the image size of the jpg a bit in Remove redundant images #122

@aheusingfeld aheusingfeld mentioned this issue Jul 15, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@aheusingfeld @programming-wolf