Skip to content

Commit bead873

Browse files
committed
remove more cruft, format codes
1 parent faf9359 commit bead873

38 files changed

+1198
-955
lines changed

.commitlintrc.js

-10
This file was deleted.

.eslintrc.js

-17
This file was deleted.

.eslintrc.local.js

-16
This file was deleted.

README.md

+190-190
Large diffs are not rendered by default.

map.js

+4-7
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,9 @@
11
import { basename } from 'path'
22

33
const map = test =>
4-
test === 'map.js'
5-
? test
6-
: test === 'unpack.js'
7-
? ['src/unpack.ts', 'src/mkdir.ts']
8-
: test === 'load-all.js'
9-
? []
10-
: `src/${test.replace(/js$/, 'ts')}`
4+
test === 'map.js' ? test
5+
: test === 'unpack.js' ? ['src/unpack.ts', 'src/mkdir.ts']
6+
: test === 'load-all.js' ? []
7+
: `src/${test.replace(/js$/, 'ts')}`
118

129
export default test => map(basename(test))

package.json

+2-1
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@
1717
"preversion": "npm test",
1818
"postversion": "npm publish",
1919
"prepublishOnly": "git push origin --follow-tags",
20-
"format": "prettier --write . --loglevel warn",
20+
"format": "prettier --write . --log-level warn",
2121
"typedoc": "typedoc --tsconfig .tshy/esm.json ./src/*.ts"
2222
},
2323
"dependencies": {
@@ -52,6 +52,7 @@
5252
"timeout": 0
5353
},
5454
"prettier": {
55+
"experimentalTernaries": true,
5556
"semi": false,
5657
"printWidth": 70,
5758
"tabWidth": 2,

scripts/generate-parse-fixtures.js

+70-57
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
import { Parser } from '../dist/esm/parse.js'
22
import fs from 'fs'
3-
import path, {dirname, resolve} from 'path'
4-
import {fileURLToPath} from 'url'
3+
import path, { dirname, resolve } from 'path'
4+
import { fileURLToPath } from 'url'
55
const __filename = fileURLToPath(import.meta.url)
66
const __dirname = dirname(__filename)
77

@@ -17,7 +17,8 @@ const makeTest = (tarfile, tardata, maxMeta, filter, strict) => {
1717
(filter ? '-filter' : '') +
1818
(strict ? '-strict' : '')
1919
const tail = (o ? '-' + o : '') + '.json'
20-
const eventsfile = parsedir + '/' + path.basename(tarfile, '.tar') + tail
20+
const eventsfile =
21+
parsedir + '/' + path.basename(tarfile, '.tar') + tail
2122

2223
const p = new Parser({
2324
maxMetaEntrySize: maxMeta,
@@ -27,57 +28,67 @@ const makeTest = (tarfile, tardata, maxMeta, filter, strict) => {
2728
const events = []
2829

2930
const pushEntry = type => entry => {
30-
events.push([type, {
31-
extended: entry.extended,
32-
globalExtended: entry.globalExtended,
33-
type: entry.type,
34-
meta: entry.meta,
35-
ignore: entry.ignore,
36-
path: entry.path,
37-
mode: entry.mode,
38-
uid: entry.uid,
39-
gid: entry.gid,
40-
uname: entry.uname,
41-
gname: entry.gname,
42-
size: entry.size,
43-
mtime: entry.mtime,
44-
atime: entry.atime,
45-
ctime: entry.ctime,
46-
linkpath: entry.linkpath,
47-
header: {
48-
cksumValid: entry.header.cksumValid,
49-
needPax: entry.header.needPax,
50-
path: entry.header.path,
51-
mode: entry.header.mode,
52-
uid: entry.header.uid,
53-
gid: entry.header.gid,
54-
size: entry.header.size,
55-
mtime: entry.header.mtime,
56-
cksum: entry.header.cksum,
57-
linkpath: entry.header.linkpath,
58-
ustar: entry.header.ustar,
59-
ustarver: entry.header.ustarver,
60-
uname: entry.header.uname,
61-
gname: entry.header.gname,
62-
devmaj: entry.header.devmaj,
63-
devmin: entry.header.devmin,
64-
ustarPrefix: entry.header.ustarPrefix,
65-
xstarPrefix: entry.header.xstarPrefix,
66-
prefixTerminator: entry.header.prefixTerminator,
67-
atime: entry.header.atime,
68-
ctime: entry.header.atime,
31+
events.push([
32+
type,
33+
{
34+
extended: entry.extended,
35+
globalExtended: entry.globalExtended,
36+
type: entry.type,
37+
meta: entry.meta,
38+
ignore: entry.ignore,
39+
path: entry.path,
40+
mode: entry.mode,
41+
uid: entry.uid,
42+
gid: entry.gid,
43+
uname: entry.uname,
44+
gname: entry.gname,
45+
size: entry.size,
46+
mtime: entry.mtime,
47+
atime: entry.atime,
48+
ctime: entry.ctime,
49+
linkpath: entry.linkpath,
50+
header: {
51+
cksumValid: entry.header.cksumValid,
52+
needPax: entry.header.needPax,
53+
path: entry.header.path,
54+
mode: entry.header.mode,
55+
uid: entry.header.uid,
56+
gid: entry.header.gid,
57+
size: entry.header.size,
58+
mtime: entry.header.mtime,
59+
cksum: entry.header.cksum,
60+
linkpath: entry.header.linkpath,
61+
ustar: entry.header.ustar,
62+
ustarver: entry.header.ustarver,
63+
uname: entry.header.uname,
64+
gname: entry.header.gname,
65+
devmaj: entry.header.devmaj,
66+
devmin: entry.header.devmin,
67+
ustarPrefix: entry.header.ustarPrefix,
68+
xstarPrefix: entry.header.xstarPrefix,
69+
prefixTerminator: entry.header.prefixTerminator,
70+
atime: entry.header.atime,
71+
ctime: entry.header.atime,
72+
},
6973
},
70-
}])
74+
])
7175
entry.resume()
7276
}
7377

7478
p.on('entry', pushEntry('entry'))
7579
p.on('ignoredEntry', pushEntry('ignoredEntry'))
76-
p.on('warn', (code, message, _data) => events.push(['warn', code, message]))
77-
p.on('error', er => events.push(['error', {
78-
message: er.message,
79-
code: er.code,
80-
}]))
80+
p.on('warn', (code, message, _data) =>
81+
events.push(['warn', code, message]),
82+
)
83+
p.on('error', er =>
84+
events.push([
85+
'error',
86+
{
87+
message: er.message,
88+
code: er.code,
89+
},
90+
]),
91+
)
8192
p.on('end', _ => events.push(['end']))
8293
p.on('nullBlock', _ => events.push(['nullBlock']))
8394
p.on('eof', _ => events.push(['eof']))
@@ -88,12 +99,14 @@ const makeTest = (tarfile, tardata, maxMeta, filter, strict) => {
8899
fs.writeFileSync(eventsfile, JSON.stringify(events, null, 2) + '\n')
89100
}
90101

91-
fs.readdirSync(tardir)
92-
.forEach(tar => {
93-
const tarfile = tardir + '/' + tar
94-
const tardata = fs.readFileSync(tarfile)
95-
maxMetaOpt.forEach(maxMeta =>
96-
filterOpt.forEach(filter =>
97-
strictOpt.forEach(strict =>
98-
makeTest(tarfile, tardata, maxMeta, filter, strict))))
99-
})
102+
fs.readdirSync(tardir).forEach(tar => {
103+
const tarfile = tardir + '/' + tar
104+
const tardata = fs.readFileSync(tarfile)
105+
maxMetaOpt.forEach(maxMeta =>
106+
filterOpt.forEach(filter =>
107+
strictOpt.forEach(strict =>
108+
makeTest(tarfile, tardata, maxMeta, filter, strict),
109+
),
110+
),
111+
)
112+
})

src/create.ts

+6-7
Original file line numberDiff line numberDiff line change
@@ -71,13 +71,12 @@ export function create(
7171
throw new TypeError('callback only supported with file option')
7272
}
7373

74-
return isSyncFile(opt)
75-
? createFileSync(opt, files)
76-
: isFile(opt)
77-
? createFile(opt, files, cb)
78-
: isSync(opt)
79-
? createSync(opt, files)
80-
: create_(opt, files)
74+
return (
75+
isSyncFile(opt) ? createFileSync(opt, files)
76+
: isFile(opt) ? createFile(opt, files, cb)
77+
: isSync(opt) ? createSync(opt, files)
78+
: create_(opt, files)
79+
)
8180
}
8281

8382
const createFileSync = (opt: TarOptionsSyncFile, files: string[]) => {

src/extract.ts

+10-13
Original file line numberDiff line numberDiff line change
@@ -77,13 +77,12 @@ export function extract(
7777
filesFilter(opt, files)
7878
}
7979

80-
return isSyncFile(opt)
81-
? extractFileSync(opt)
82-
: isFile(opt)
83-
? extractFile(opt, cb)
84-
: isSync(opt)
85-
? extractSync(opt)
86-
: extract_(opt)
80+
return (
81+
isSyncFile(opt) ? extractFileSync(opt)
82+
: isFile(opt) ? extractFile(opt, cb)
83+
: isSync(opt) ? extractSync(opt)
84+
: extract_(opt)
85+
)
8786
}
8887

8988
// construct a filter that limits the file entries listed
@@ -109,8 +108,9 @@ const filesFilter = (opt: TarOptions, files: string[]) => {
109108
return ret
110109
}
111110

112-
opt.filter = filter
113-
? (file, entry) =>
111+
opt.filter =
112+
filter ?
113+
(file, entry) =>
114114
filter(file, entry) && mapHas(stripTrailingSlashes(file))
115115
: file => mapHas(stripTrailingSlashes(file))
116116
}
@@ -130,10 +130,7 @@ const extractFileSync = (opt: TarOptionsSyncFile) => {
130130
stream.pipe(u)
131131
}
132132

133-
const extractFile = (
134-
opt: TarOptionsFile,
135-
cb?: () => void,
136-
) => {
133+
const extractFile = (opt: TarOptionsFile, cb?: () => void) => {
137134
const u = new Unpack(opt)
138135
const readSize = opt.maxReadSize || 16 * 1024 * 1024
139136

src/get-write-flag.ts

+3-2
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,7 @@ const UV_FS_O_FILEMAP =
2222
const fMapEnabled = isWindows && !!UV_FS_O_FILEMAP
2323
const fMapLimit = 512 * 1024
2424
const fMapFlag = UV_FS_O_FILEMAP | O_TRUNC | O_CREAT | O_WRONLY
25-
export const getWriteFlag = !fMapEnabled
26-
? () => 'w'
25+
export const getWriteFlag =
26+
!fMapEnabled ?
27+
() => 'w'
2728
: (size: number) => (size < fMapLimit ? fMapFlag : 'w')

0 commit comments

Comments
 (0)