Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: wallet:export and wallet:address changes #3615

Open
irontankfish opened this issue Mar 7, 2023 · 2 comments
Open

Feature: wallet:export and wallet:address changes #3615

irontankfish opened this issue Mar 7, 2023 · 2 comments
Labels
feature request New functionality added to Iron Fish

Comments

@irontankfish
Copy link

irontankfish commented Mar 7, 2023

Description

I noticed that in the discord chat, people were confused where they could get their public key, and what the export address was. In fact, it is a bit confusing for someone who isn't a developer.

Currently we have:

ironfish wallet:export
xyz

ironfish wallet:address
Account: abc, publicKey: xyz

There are two potential fixes. You can decide which one to pick:

  1. We make both addresses consistent, and display a message
Ironfish wallet:export
Account: abc
Private key: xyz
Keep this address in a secure place. You can use it later to recover your wallet

Ironfish wallet:address
Account: abc
Public key: xyz
You can use this address for sending and receiving IRON.
  1. Same as above, and we update the export name to privateKey, and address name to publicKey
Ironfish wallet:privateKey
Private key: xyz
Keep this address in a secure place. You may use it later to import your wallet

Ironfish wallet:publicKey
Public key: xyz
You may use this address for sending and receiving IRON.

This is a quick fix, so I can get started on fixing it.

@irontankfish irontankfish added the feature request New functionality added to Iron Fish label Mar 7, 2023
@wd021
Copy link
Contributor

wd021 commented Mar 8, 2023

i think a lot of the confusion was people from previous versions who weren't aware of the changes made recently.

@irontankfish
Copy link
Author

irontankfish commented Mar 8, 2023

Yes, I agree. But adding in the message after displaying the private, and public key would be useful for current and future users, which I suggest in the feature request. Currently we don't have any message displaying, which I feel is important when displaying the keys to our users.

We can also change the name of export, and address to privateKey, and publicKey, but this would be up to the developers, whether they might prefer it that way or not.

I have updated the description, with the before output. This should make it a lot easier to understand

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New functionality added to Iron Fish
Projects
None yet
Development

No branches or pull requests

2 participants