Compilation error after "Replace linker_assert() with build_assert()"

[EnikeevIlya]

Hello.

After your update 4b7d9a6 , I encounter the following error:

At the compilation stage at this point of the ansible script:

- name: Compile iPXE bootloader for Legacy BIOS with debug flags
  ansible.builtin.shell: |
    make clean
    make -j{{ make_num_jobs }} \
         EMBED={{ bootloader_filename }} \
         DEBUG={{ ipxe_debug_options }} \
         TRUST={{ trust_files }} \
         bin/ipxe.dsk \
         bin/ipxe.pdsk \
         bin/ipxe.lkrn \
         bin/ipxe.kpxe \
         bin/undionly.kpxe
  args:
    chdir: "{{ ipxe_source_dir }}/src"
  when: ipxe_debug_enabled | bool

I'm not sure, but I think the problem is on your side. Correct me if I'm wrong. Thank you.

[NiKiZe]

Instead of an unreadable image, post text.

Make sure you also include version of gcc and binutils.

[EnikeevIlya]

"stderr": "In file included from <command-line>:\ncrypto/aes.c: In function ‘aes_gcm_setkey’:\ninclude/assert.h:82:10: error: call to ‘build_assert_805’ declared with attribute error: build_assert(( ( void * ) &context->raw ) == ( ( void * ) context->gcm.raw_ctx )) failed\n   82 |    _C2 ( build_assert_, __LINE__ ) ();       \\\n      |          ^\n./include/compiler.h:46:21: note: in definition of macro ‘_C1’\n   46 | #define _C1( x, y ) x ## y\n      |                     ^\ninclude/assert.h:82:4: note: in expansion of macro ‘_C2’\n   82 |    _C2 ( build_assert_, __LINE__ ) ();       \\\n      |    ^~~\ninclude/ipxe/gcm.h:92:2: note: in expansion of macro ‘build_assert’\n   92 |  build_assert ( ( ( void * ) &context->gcm ) == ctx );  \\\n      |  ^~~~~~~~~~~~\ncrypto/aes.c:805:1: note: in expansion of macro ‘GCM_CIPHER’\n  805 | GCM_CIPHER ( aes_gcm, aes_gcm_algorithm,\n      | ^~~~~~~~~~\ncrypto/aes.c: At top level:\ncc1: error: unrecognized command line option ‘-Wno-dangling-pointer’ [-Werror]\ncc1: all warnings being treated as errors\nmake: *** [Makefile.housekeeping:964: bin/aes.o] Error 1",
    "stderr_lines": [
        "In file included from <command-line>:",
        "crypto/aes.c: In function ‘aes_gcm_setkey’:",
        "include/assert.h:82:10: error: call to ‘build_assert_805’ declared with attribute error: build_assert(( ( void * ) &context->raw ) == ( ( void * ) context->gcm.raw_ctx )) failed",
        "   82 |    _C2 ( build_assert_, __LINE__ ) ();       \\",
        "      |          ^",
        "./include/compiler.h:46:21: note: in definition of macro ‘_C1’",
        "   46 | #define _C1( x, y ) x ## y",
        "      |                     ^",
        "include/assert.h:82:4: note: in expansion of macro ‘_C2’",
        "   82 |    _C2 ( build_assert_, __LINE__ ) ();       \\",
        "      |    ^~~",
        "include/ipxe/gcm.h:92:2: note: in expansion of macro ‘build_assert’",
        "   92 |  build_assert ( ( ( void * ) &context->gcm ) == ctx );  \\",
        "      |  ^~~~~~~~~~~~",
        "crypto/aes.c:805:1: note: in expansion of macro ‘GCM_CIPHER’",
        "  805 | GCM_CIPHER ( aes_gcm, aes_gcm_algorithm,",
        "      | ^~~~~~~~~~",
        "crypto/aes.c: At top level:",
        "cc1: error: unrecognized command line option ‘-Wno-dangling-pointer’ [-Werror]",
        "cc1: all warnings being treated as errors",
        "make: *** [Makefile.housekeeping:964: bin/aes.o] Error 1"
    ],

[EnikeevIlya]

gcc (Ubuntu 9.4.0-1ubuntu1~20.04.2) 9.4.0
(GNU Binutils for Ubuntu) 2.34

[lukemcdo]

Encountered the same issue from OpenSUSE 15.5 using gcc 7-3.9.1 and binutils 2.41-150100.7.46.1 which was resolved by resetting to 6ca597e from the 14th. Did not try the one-newer static assert commit.

[NiKiZe]

#1103 was also old versions of build tools that failed.

Maybe possible to use a bit more recent system to build? Or concider use of docker images or VMs?

[lukemcdo]

Rather not build on a rolling distro if if I don't have to, and a lot of mainstream distributions distribute old versions of build tools.

I'm fine using the commit I linked above, but I would appreciate if it could get tagged.

[EnikeevIlya]

I support every word you have said above.

[mcb30]

I can reproduce the error on a CentOS 7 container. It's on the queue to deal with, after wrapping up some other work.

[jstncno]

Can confirm this error is also reproducible in a Ubuntu 16.04.7 LTS container

[g3rhard]

In my opinion it worth to open issue about this.
Also can reproduce the same behavior on Ubuntu focal-20231211

[weakcamel]

Seeing the same problems on

• Ubuntu Jammy with gcc 12
• Ubuntu Bionic with gcc 7.5.0 and binutils 2.30 as well as gcc-5 (!)

@EnikeevIlya did you end up opening an issue?