Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecation warnings and associated code for previous config structures #127

Open
3 tasks done
riley-harper opened this issue Nov 20, 2023 · 0 comments · May be fixed by #186
Open
3 tasks done

Remove deprecation warnings and associated code for previous config structures #127

riley-harper opened this issue Nov 20, 2023 · 0 comments · May be fixed by #186
Labels
configuration Related to configuration and its syntax
Milestone
v4.0.0

Comments

@riley-harper
Copy link
Contributor

riley-harper commented Nov 20, 2023 •
edited
Loading

There are several deprecation warnings sprinkled throughout the code that warn about previous config structures. The code around these warnings handles the previous structures for for backwards compatibility. We can remove these as we move forward with the new config structure. This is technically a breaking change and goes nicely with the planned configuration upgrades, so this can happen in hlink v4.

The deprecation messages are...

  • The config value 'blocking_steps' has been renamed to 'blocking' and is now just a single array of objects (matching)
  • The config value 'column_mappings' is no longer a nested (double) array and is now an array of objects (preprocessing)
  • The 'mapping' transform no longer takes the 'values' parameter with a list of mappings in dictionaries; instead each mapping should be its own transform (core)
@riley-harper riley-harper added this to the v4.0.0 milestone Nov 20, 2023
@riley-harper riley-harper added the configuration Related to configuration and its syntax label Aug 27, 2024
riley-harper added a commit that referenced this issue Mar 5, 2025
@riley-harper
[#127] Update test to avoid using blocking_steps
305358a
riley-harper added a commit that referenced this issue Mar 5, 2025
@riley-harper
[#127] Remove support for "blocking_steps"
3543afc 
This is an old, deprecated way of specifying blocking.
riley-harper added a commit that referenced this issue Mar 5, 2025
@riley-harper
[#127] Inline matching._helpers.get_blocking()
08ac712 
Now that blocking_steps isn't supported, it's simpler to inline this private
helper function.
riley-harper added a commit that referenced this issue Mar 5, 2025
@riley-harper
[#127] Remove support for old column_mappings format
1a14cea 
This has been deprecated in favor of the current column_mappings format.
riley-harper added a commit that referenced this issue Mar 5, 2025
@riley-harper
[#127] Remove support for deprecated form of mapping transforms
9c99a44
@riley-harper riley-harper mentioned this issue Mar 6, 2025
Merged
riley-harper added a commit that referenced this issue Mar 6, 2025
@riley-harper
[#127] Add tests for the "mapping" column mapping transform
727373f
riley-harper added a commit that referenced this issue Mar 6, 2025
@riley-harper
[#127] Update documentation for the mapping transform
2004b2e 
This documentation was unfortunately using the old, deprecated form. So I've
updated it to use the new form instead.
@riley-harper riley-harper linked a pull request Mar 6, 2025 that will close this issue
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
configuration Related to configuration and its syntax
Projects
None yet
Milestone
v4.0.0
Development

Successfully merging a pull request may close this issue.

Version 4.0.0 ipums/hlink
1 participant
@riley-harper