submit to CRAN

Author: rafapereirabr

.Rbuildignore

@@ -9,3 +9,5 @@ README.md
 ^docs$
 ^pkgdown$
 ^\.github$
+^cran-comments\.md$
+^CRAN-SUBMISSION$

CRAN-SUBMISSION

@@ -0,0 +1,3 @@
+Version: 2.1-2
+Date: 2024-10-08 02:54:14 UTC
+SHA: a5a0602be1ac6934e0e3b8e7ae0c36c5b35f47f2

DESCRIPTION

@@ -1,7 +1,7 @@
 Type: Package
 Package: gtfs2gps
 Title: Converting Transport Data from GTFS Format to GPS-Like Records
-Version: 2.1-1
+Version: 2.1-2
 Authors@R: c(person(given="Rafael H. M.", family="Pereira", email="[email protected]", role="aut", comment = c(ORCID = "0000-0003-2125-7465")),
             person(given="Pedro R.", family="Andrade", email="[email protected]", role=c("aut", "cre"), comment = c(ORCID = "0000-0001-8675-4046")),
             person(given="Joao", family="Bazzo", role="aut", comment = c(ORCID = "0000-0003-4536-5006")),

NEWS.md

@@ -5,8 +5,7 @@
 * Minor changes
   * puts package back on CRAN
   * remove {magrittr} from Suggests
-  * Clarifies in the documentation of the parameter `ncores` is , by default, all available cores minus one. closes #271
-
+  * Clarifies in the documentation the default behavior of the parameter `ncores`. closes #271. When `parallel = FALSE`, this argument is ignored. When `parallel = TRUE`, then by default the function uses all available cores minus one.
 
 # gtfs2gps v2.1-1
 

R/gtfs2gps.R

@@ -21,9 +21,9 @@
 #' strategy "multisession" internally.
 #' Note that it is possible to create your own plan before calling gtfs2gps().
 #' In this case, do not use this argument.
-#' @param ncores Number of cores to be used in parallel execution. If parallel is
-#'        FALSE then this argument is ignored. By Default, the function uses all 
-#'        available cores minus one.
+#' @param ncores Number of cores to be used in parallel execution. When 
+#'        `parallel = FALSE`, this argument is ignored. When `parallel = TRUE`,
+#'        then by default the function uses all available cores minus one.
 #' @param strategy This argument is deprecated. Please use argument plan instead or
 #' use future::plan() directly.
 #' @param filepath Output file path. As default, the output is returned when gtfs2gps finishes.

cran-comments.md

@@ -0,0 +1,12 @@
+## R CMD check results
+
+── R CMD check results ─────────────────────────────────── gtfs2gps 2.1-2 ────
+Duration: 4m 47.5s
+
+0 errors ✔ | 0 warnings ✔ | 0 notes ✔
+
+* The package was removed from CRAN because it depends on another package {gtfstools} that had been removed from CRAN. The {gtfstools} package has been restablished on CRAN, so this submission is intented to restablish {gtfs2gps} on CRAN.
+* In addition to that, this version fixes a couple minor issues, namely:
+  * removes {magrittr} from Suggests
+  * Clarifies in the documentation the default behavior of the parameter `ncores`. closes #271. When `parallel = FALSE`, this argument is ignored. When `parallel = TRUE`, then by default the function uses all available cores minus one.
+

man/gtfs2gps.Rd

@@ -20,7 +20,7 @@ test_that("gps_as_sflinestring", {
   # -----
   # test to fix NA values
   gps <- read_gtfs(system.file("extdata/poa.zip", package="gtfs2gps")) |>
-    gtfstools::filter_by_shape_id(.,"176-1") |> 
+    gtfstools::filter_by_shape_id("176-1") |> 
     filter_single_trip() |> 
     gtfs2gps() |> 
     adjust_speed() |> 

tests/testthat/test_gps_as_sflinestring.R

@@ -16,44 +16,6 @@ library(gtfs2gps)
 devtools::document(pkg = ".")
 
 
-# calculate Distance between successive points
-new_stoptimes[ , dist := geosphere::distGeo(matrix(c(shape_pt_lon, shape_pt_lat), ncol = 2),
-                                            matrix(c(data.table::shift(shape_pt_lon, type="lag"), data.table::shift(shape_pt_lat, type="lag")), ncol = 2))/1000]
-
-
-
-
-#### SPEED
-poa <- read_gtfs(system.file("extdata/poa.zip", package = "gtfs2gps"))
-
-system.time(poa_gps <- gtfs2gps(poa))
-user  system elapsed 
-9.34    0.15    9.67 
-7.59    0.15    7.73 
-7.15    0.36    7.51 
-
-spo <- read_gtfs(system.file("extdata/saopaulo.zip", package = "gtfs2gps"))
-system.time(spo_gps <- gtfs2gps(spo))
-user  system elapsed 
-79.97    1.71   82.67 
-79.31    1.68   81.69
-77.51    1.37   80.29 
-##### INPUT  ------------------------
-  # normal
-  gtfsn <- './inst/extdata/poa.zip'
-  # freq based
-  gtfsf <- './inst/extdata/saopaulo.zip'
-
-emtu <- "R:/Dropbox/bases_de_dados/GTFS/SP GTFS/GTFS EMTU_20190815.zip"
-  
-  
-##### TESTS normal fun ------------------------
-  # normal data
-  system.time(  normal <- gtfs2gps_dt_parallel2(emtu) ) # 61.55  secs
-
-  # freq data
-  system.time(  normfreq <- gtfs2gps_dt_parallel(gtfsf) ) # 130.50 secs
-  
 
 ##### Coverage ------------------------
 
@@ -294,77 +256,33 @@ devtools::check(pkg = ".",  cran = TRUE, env_vars = c(NOT_CRAN = "false"))
 
 
 
-# build binary  ----------------
-system("R CMD build . --resave-data") # build tar.gz
-system("R CMD build gtfs2gps --resave-data") # build tar.gz
-# devtools::build(pkg = "gtfs2gps", path=".", binary = TRUE, manual=TRUE)
-
-# Check package errors
-# devtools::check("gtfs2gps")
-system("R CMD check gtfs2gps_1.0.tar.gz")
-system("R CMD check --as-cran gtfs2gps_1.0-0.tar.gz")
-
-
-
-
-
-
-
 
 
 
 
-a <- all_feeds[[1]]$stops$stop_id
 
-b <- all_feeds[[2]]$stops$stop_id
 
 
-intersect(a,b, a)
 
-Reduce(intersect, list(a,b,c))
 
+##### website  ----------------------
+library(pkgdown)
+library(usethis)
 
-all_feeds[[c(1,2)]]$stops$stop_id
-
-
-
-spo <- system.file("extdata/saopaulo.zip", package = "gtfs2gps")
-poa <- system.file("extdata/poa.zip", package = "gtfs2gps")
-gtfs_list <- list(spo, poa)
-
-# read all feeds
-all_feeds <- lapply(gtfs_list, read_gtfs)
-
-
-##### STOPS ----------------------
-
-# extract stops from all GTFS feeds
-stops <- sapply(all_feeds, "[", 'stops')
-
-# extract stop ids
-stop_ids <-  sapply(stops, "[[", 'stop_id')
-
-# check inersection between ids
-output_intersect <- Reduce(intersect, stop_ids)
+pkgdown::build_site()
 
-# if there is any overlap
-if( length(output_intersect) = 0){ 
-  stops <- rbindlist(stops, fill = T)
-}
 
 
 
 
-for(i in 1:length(agency_ids)){
-  stop_ids[i] <- sprintf("%s_%s", agency_ids[[i]], stop_ids[[i]])
-  # route_ids[i] <- sprintf("%s_%s", agency_ids[[i]], route_ids[[i]])
-  # trip_ids[i] <- sprintf("%s_%s", agency_ids[[i]], trip_ids[[i]])
-  # ...
-}
+# submit to CRAN -----------------
+usethis::use_cran_comments('teste 2222, , asdadsad')
 
+urlchecker::url_check()
+devtools::check(remote = TRUE, manual = TRUE)
+devtools::check_win_release()
+devtools::check_mac_release()
+rhub::check_for_cran(show_status = FALSE)
 
-##### website  ----------------------
-library(pkgdown)
-library(usethis)
 
-pkgdown::build_site()
+devtools::submit_cran()