Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

songTableInfoConfig isn't used when there are no scan results #81

Closed
leo60228 opened this issue Feb 7, 2025 · 2 comments
Closed

songTableInfoConfig isn't used when there are no scan results #81

leo60228 opened this issue Feb 7, 2025 · 2 comments

Comments

@leo60228
Copy link

leo60228 commented Feb 7, 2025

songTableInfoConfig is copied to songTableInfoPlayback by Profile::ApplyScanToPlayback(). However, in the scanResults.size() == 0 path, this is never called. This results in songTableInfoPlayback being default-initialized, and thus the song table is read from 0x0 in the ROM, which is unlikely to go well.

@ipatix
Copy link
Owner

ipatix commented Feb 10, 2025

Good catch. Turns out I never really tested this code path. I am aware agbplay is currently unable to scan a couple of games, which it used to be able to before. Probably the reason why I haven't bothered to test it yet.

@ipatix ipatix closed this as completed in 865e555 Feb 12, 2025
@ipatix
Copy link
Owner

ipatix commented Feb 12, 2025

Can you try, if the issue is fixed? If not, feel free to reopen.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants