Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NodeJS support for Lambda Layers #44

Closed
ewindisch opened this issue Apr 12, 2019 · 4 comments
Closed

NodeJS support for Lambda Layers #44

ewindisch opened this issue Apr 12, 2019 · 4 comments

Comments

@ewindisch
Copy link
Contributor

ewindisch commented Apr 12, 2019

Lambda layers: Lambda can't find the file @iopipe/iopipe.js

A readme section was added describing how to manually integrate IOpipe to resolve this error, but we need to be able to integrate w/o code modifications.

I think this used to work... I'm not sure what changed, but we can no longer import the @iopipe/iopipe module as a handler directly.

@mrickard mrickard self-assigned this Apr 12, 2019
@mrickard mrickard added the bug label Apr 12, 2019
@kolanos
Copy link
Contributor

kolanos commented Apr 12, 2019

@ewindisch Unfortunately the fix is that the Node.js runtime needs to perform a require.resolve against the NODE_PATH. This is functionally how the Python runtime works, where the runtime bootstrap sets the sys.path. I have no idea why the Node.js runtime isn't doing something similar.

@ewindisch ewindisch assigned ewindisch and unassigned mrickard Apr 25, 2019
@ewindisch ewindisch changed the title Lambda layers: Lambda can't find the file @iopipe/iopipe.js NodeJS support for Lambda Layers Jun 7, 2019
@ewindisch
Copy link
Contributor Author

This is not currently supported by AWS.

We will be switching to using a custom provider in the short-term:
iopipe/iopipe-cli#19

@ewindisch
Copy link
Contributor Author

This issue should remain open until there is native support in the AWS runtimes.

The existing code works with custom runtimes. We will need to update documentation for layers as part of this, or another, issue.

https://github.com/iopipe/iopipe-cli will not be blocked by use of custom runtimes.

@kolanos
Copy link
Contributor

kolanos commented Jun 19, 2019

This is an issue with the runtime itself.

@kolanos kolanos closed this as completed Jun 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants