Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: IonTabButton doesn't have default HTML event attributes typed #29174

Open
3 tasks done
aeharding opened this issue Mar 18, 2024 · 1 comment
Open
3 tasks done

bug: IonTabButton doesn't have default HTML event attributes typed #29174

aeharding opened this issue Mar 18, 2024 · 1 comment
Labels
package: react @ionic/react package type: bug a confirmed bug report

Comments

@aeharding
Copy link
Contributor

Prerequisites

Ionic Framework Version

v7.x

Current Behavior

IonTabButton is missing regular HTML types (onPointerDown, onTouchEnd, onTouchMove, etc)

Expected Behavior

Should have proper types.

Steps to Reproduce

Try to add onPointerDown to IonTabButton in React. Typescript will complain, but the touch end handler will be properly connected/called.

Code Reproduction URL

https://stackblitz.com/edit/wl7fhb-xaawyq?file=src%2Fmain.tsx

Ionic Info

N/A - stackblitz

Additional Information

No response

@thetaPC
Copy link
Contributor

thetaPC commented Mar 21, 2024

Thank you for submitting the issue!

I was able to replicate it. I verified that onClick doesn't cause any type errors. I would recommend using that as a workaround.

@thetaPC thetaPC added package: react @ionic/react package type: bug a confirmed bug report labels Mar 21, 2024
@ionitron-bot ionitron-bot bot removed the triage label Mar 21, 2024
@thetaPC thetaPC removed their assignment Mar 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: react @ionic/react package type: bug a confirmed bug report
Projects
None yet
Development

No branches or pull requests

2 participants