Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: card modal doesn't add border radius until the modal is fully opened on iOS #29129

Open
3 tasks done
zacksmash opened this issue Mar 8, 2024 · 2 comments
Open
3 tasks done
Labels
needs: investigation This issue is waiting on more investigation from the Ionic Team.

Comments

@zacksmash
Copy link

zacksmash commented Mar 8, 2024

Prerequisites

Ionic Framework Version

v7.x

Current Behavior

When using the "Card' modal style, the "body" behind the modal window doesn't get the radius edges applied until after the modal window has fully opened. This only happens if opening the modal from an IonList > IonItem with the button attribute.

Expected Behavior

The Card modal should have the radius edges, like normal

Steps to Reproduce

  1. Create an IonList element, with an IonItem that has the button attribute. Then use that IonItem to open an IonModal, with a presentingElement for the Card effect.
<template>
  <ion-page ref="presentingElement">
    <ion-header :translucent="true">
      <ion-toolbar>
        <ion-title>Blank</ion-title>
      </ion-toolbar>
    </ion-header>

    <ion-content :fullscreen="true">
      <ion-header collapse="condense">
        <ion-toolbar>
          <ion-title size="large">Blank</ion-title>
        </ion-toolbar>
      </ion-header>

      <ion-list>
        <ion-item button @click="isOpen = true">
          <ion-label>List Item Label</ion-label>
        </ion-item>

        <ion-modal ref="modal" :is-open="isOpen" :presenting-element="$refs?.presentingElement?.$el">
          <ion-header>
            <ion-toolbar>
              <ion-title>Modal</ion-title>
              <ion-buttons slot="end">
                <ion-button @click="isOpen = false">Close</ion-button>
              </ion-buttons>
            </ion-toolbar>
          </ion-header>
          <ion-content class="ion-padding">
            Some Modal Content
          </ion-content>
        </ion-modal>
      </ion-list>
    </ion-content>
  </ion-page>
</template>

<script setup>
import { IonContent, IonHeader, IonPage, IonTitle, IonToolbar, IonList, IonItem, IonLabel, IonButtons, IonButton, IonModal } from '@ionic/vue';
import { ref } from 'vue';

const isOpen = ref(false);
</script>

Code Reproduction URL

Stackblitz URL

Ionic Info

Ionic:

Ionic CLI : 7.2.0 (/Users/Zack/.nvm/versions/node/v20.11.1/lib/node_modules/@ionic/cli)
Ionic Framework : @ionic/vue 7.7.4

Capacitor:

Capacitor CLI : 5.7.2
@capacitor/android : not installed
@capacitor/core : 5.7.2
@capacitor/ios : 5.7.2

Utility:

cordova-res : not installed globally
native-run : 2.0.1

System:

NodeJS : v20.11.1 (/Users/Zack/.nvm/versions/node/v20.11.1/bin/node)
npm : 10.4.0
OS : macOS Sonoma 14.3.1

Additional Information

Duplicate of #28469, with better reproduction instructions.

@ionitron-bot ionitron-bot bot added the triage label Mar 8, 2024
@liamdebeasi liamdebeasi added the ionitron: needs reproduction a code reproduction is needed from the issue author label Mar 8, 2024
Copy link

ionitron-bot bot commented Mar 8, 2024

Thanks for the issue! This issue has been labeled as needs reproduction. This label is added to issues that need a code reproduction.

Please reproduce this issue in an Ionic starter application and provide a way for us to access it (GitHub repo, StackBlitz, etc). Without a reliable code reproduction, it is unlikely we will be able to resolve the issue, leading to it being closed.

If you have already provided a code snippet and are seeing this message, it is likely that the code snippet was not enough for our team to reproduce the issue.

For a guide on how to create a good reproduction, see our Contributing Guide.

@ionitron-bot ionitron-bot bot removed the triage label Mar 8, 2024
@zacksmash
Copy link
Author

@brandyscarney Added Stackblitz URL to main entry.

This will need to be reproduced using Safari or in the Simulator.

@amandaejohnston amandaejohnston added triage and removed ionitron: needs reproduction a code reproduction is needed from the issue author labels Mar 11, 2024
@brandyscarney brandyscarney added the type: bug a confirmed bug report label Mar 12, 2024
@ionitron-bot ionitron-bot bot removed the triage label Mar 12, 2024
@brandyscarney brandyscarney changed the title Modal appearance is inconsistent on iOS bug: card modal doesn't add border radius until the modal is fully opened on iOS Mar 12, 2024
@brandyscarney brandyscarney removed their assignment Mar 12, 2024
@liamdebeasi liamdebeasi added needs: investigation This issue is waiting on more investigation from the Ionic Team. and removed type: bug a confirmed bug report labels Mar 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs: investigation This issue is waiting on more investigation from the Ionic Team.
Projects
None yet
Development

No branches or pull requests

4 participants