{"payload":{"feedbackUrl":"https://github.com/orgs/community/discussions/53140","repo":{"id":12256376,"defaultBranch":"main","name":"ionic-framework","ownerLogin":"ionic-team","currentUserCanPush":false,"isFork":false,"isEmpty":false,"createdAt":"2013-08-20T23:06:02.000Z","ownerAvatar":"https://avatars.githubusercontent.com/u/3171503?v=4","public":true,"private":false,"isOrgOwned":true},"refInfo":{"name":"","listCacheKey":"v0:1715210533.0","currentOid":""},"activityList":{"items":[{"before":"72129b80148e37a982e4e5894dd3eab08029de5b","after":"e4999caaff1effdfec9d69080f13bd93c261aba4","ref":"refs/heads/FW-6096","pushedAt":"2024-05-08T23:34:05.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"thetaPC","name":"Maria Hutt","path":"/thetaPC","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/13530427?s=80&v=4"},"commit":{"message":"test(input): update todo comment","shortMessageHtmlLink":"test(input): update todo comment"}},{"before":"3dfcc41b99049a8cfed9e57422bd78358d0ad507","after":"72129b80148e37a982e4e5894dd3eab08029de5b","ref":"refs/heads/FW-6096","pushedAt":"2024-05-08T23:31:37.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"thetaPC","name":"Maria Hutt","path":"/thetaPC","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/13530427?s=80&v=4"},"commit":{"message":"test(input): remove only","shortMessageHtmlLink":"test(input): remove only"}},{"before":"693f1b9e5eae4290a023cd81b992f8b7aff20f75","after":"3dfcc41b99049a8cfed9e57422bd78358d0ad507","ref":"refs/heads/FW-6096","pushedAt":"2024-05-08T23:30:37.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"thetaPC","name":"Maria Hutt","path":"/thetaPC","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/13530427?s=80&v=4"},"commit":{"message":"test(input): revert as fix was open in another PR","shortMessageHtmlLink":"test(input): revert as fix was open in another PR"}},{"before":"183b329ca70c92449ae4b7f8196615dbe43e408d","after":"693f1b9e5eae4290a023cd81b992f8b7aff20f75","ref":"refs/heads/FW-6096","pushedAt":"2024-05-08T23:28:43.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"thetaPC","name":"Maria Hutt","path":"/thetaPC","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/13530427?s=80&v=4"},"commit":{"message":"docs(input): update comment","shortMessageHtmlLink":"docs(input): update comment"}},{"before":"11f17ec5918f26738691de1613bf1d28980ef656","after":"183b329ca70c92449ae4b7f8196615dbe43e408d","ref":"refs/heads/FW-6096","pushedAt":"2024-05-08T23:26:43.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"thetaPC","name":"Maria Hutt","path":"/thetaPC","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/13530427?s=80&v=4"},"commit":{"message":"refactor(input): add todo for other themes","shortMessageHtmlLink":"refactor(input): add todo for other themes"}},{"before":"b75ede66f13c5d679b47abbddfdef07346d9b28d","after":null,"ref":"refs/heads/FW-6062","pushedAt":"2024-05-08T23:22:13.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"thetaPC","name":"Maria Hutt","path":"/thetaPC","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/13530427?s=80&v=4"}},{"before":"7c7c483ab912da6697de33476cf09900f68eb808","after":"a58d9fa2e163ddfa6c9a6dbc1eb97d79e12e1c99","ref":"refs/heads/next","pushedAt":"2024-05-08T23:22:12.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"thetaPC","name":"Maria Hutt","path":"/thetaPC","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/13530427?s=80&v=4"},"commit":{"message":"feat(many): expand global config for icons (#29373)\n\nCo-authored-by: Brandy Carney ","shortMessageHtmlLink":"feat(many): expand global config for icons (#29373)"}},{"before":"a250f4fe6ea19c25e24b4341ad75034bb3699dae","after":"11f17ec5918f26738691de1613bf1d28980ef656","ref":"refs/heads/FW-6096","pushedAt":"2024-05-08T23:14:50.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"thetaPC","name":"Maria Hutt","path":"/thetaPC","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/13530427?s=80&v=4"},"commit":{"message":"test(input): add soft snapshots","shortMessageHtmlLink":"test(input): add soft snapshots"}},{"before":"bab964859b2420948fbbd7525207c40d224ba7bc","after":"a250f4fe6ea19c25e24b4341ad75034bb3699dae","ref":"refs/heads/FW-6096","pushedAt":"2024-05-08T23:08:00.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"thetaPC","name":"Maria Hutt","path":"/thetaPC","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/13530427?s=80&v=4"},"commit":{"message":"test(input): remove more old images","shortMessageHtmlLink":"test(input): remove more old images"}},{"before":"0def9ddc5330c3d2e7c244d8167568f6fe3d6f25","after":"bab964859b2420948fbbd7525207c40d224ba7bc","ref":"refs/heads/FW-6096","pushedAt":"2024-05-08T23:06:35.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"thetaPC","name":"Maria Hutt","path":"/thetaPC","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/13530427?s=80&v=4"},"commit":{"message":"test(input): remove old images","shortMessageHtmlLink":"test(input): remove old images"}},{"before":"78c5c7a64a850e8317b9f10ecae96b4b88436481","after":"0def9ddc5330c3d2e7c244d8167568f6fe3d6f25","ref":"refs/heads/FW-6096","pushedAt":"2024-05-08T23:02:05.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"thetaPC","name":"Maria Hutt","path":"/thetaPC","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/13530427?s=80&v=4"},"commit":{"message":"test(input): revert snapshots","shortMessageHtmlLink":"test(input): revert snapshots"}},{"before":"7333376506afb2e18c97d6a007ac7e464ea635dc","after":"e13db0f9ca439b50b9514d056678d01b5e77656b","ref":"refs/heads/remove-only","pushedAt":"2024-05-08T22:58:10.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"thetaPC","name":"Maria Hutt","path":"/thetaPC","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/13530427?s=80&v=4"},"commit":{"message":"test(input): remove the .only within fill","shortMessageHtmlLink":"test(input): remove the .only within fill"}},{"before":null,"after":"7333376506afb2e18c97d6a007ac7e464ea635dc","ref":"refs/heads/remove-only","pushedAt":"2024-05-08T22:57:09.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"thetaPC","name":"Maria Hutt","path":"/thetaPC","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/13530427?s=80&v=4"},"commit":{"message":"fix(input): implement default shape for ionic theme (#29469)\n\nCo-authored-by: Brandy Carney ","shortMessageHtmlLink":"fix(input): implement default shape for ionic theme (#29469)"}},{"before":"6bb7baaf6f63e9fb56249beeb4b1586c0a46bdc0","after":"b75ede66f13c5d679b47abbddfdef07346d9b28d","ref":"refs/heads/FW-6062","pushedAt":"2024-05-08T22:52:30.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"thetaPC","name":"Maria Hutt","path":"/thetaPC","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/13530427?s=80&v=4"},"commit":{"message":"chore(searchbar): run lint","shortMessageHtmlLink":"chore(searchbar): run lint"}},{"before":"ccf4bf0381dcd3f1b9db7ce90d175c0033da57a1","after":"78c5c7a64a850e8317b9f10ecae96b4b88436481","ref":"refs/heads/FW-6096","pushedAt":"2024-05-08T22:47:59.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"thetaPC","name":"Maria Hutt","path":"/thetaPC","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/13530427?s=80&v=4"},"commit":{"message":"Merge branch 'ROU-4848' of github.com:ionic-team/ionic-framework into FW-6096","shortMessageHtmlLink":"Merge branch 'ROU-4848' of github.com:ionic-team/ionic-framework into…"}},{"before":"1c6b7a935e84ac034a4e9c24644f59c97e9d360f","after":"6bb7baaf6f63e9fb56249beeb4b1586c0a46bdc0","ref":"refs/heads/FW-6062","pushedAt":"2024-05-08T21:19:21.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"thetaPC","name":"Maria Hutt","path":"/thetaPC","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/13530427?s=80&v=4"},"commit":{"message":"Update core/src/components/searchbar/searchbar.tsx\n\nCo-authored-by: Brandy Carney ","shortMessageHtmlLink":"Update core/src/components/searchbar/searchbar.tsx"}},{"before":"67693ea96dcc5247198f7d505abf4ab6ca2beb5d","after":"1c6b7a935e84ac034a4e9c24644f59c97e9d360f","ref":"refs/heads/FW-6062","pushedAt":"2024-05-08T20:58:37.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"thetaPC","name":"Maria Hutt","path":"/thetaPC","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/13530427?s=80&v=4"},"commit":{"message":"fix(searchbar): revert testing","shortMessageHtmlLink":"fix(searchbar): revert testing"}},{"before":"8ad4e58a32ba8c4ed02cf46375a9cbedd4f20e16","after":"67693ea96dcc5247198f7d505abf4ab6ca2beb5d","ref":"refs/heads/FW-6062","pushedAt":"2024-05-08T20:57:40.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"thetaPC","name":"Maria Hutt","path":"/thetaPC","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/13530427?s=80&v=4"},"commit":{"message":"fix(toggle): remove wrong icon","shortMessageHtmlLink":"fix(toggle): remove wrong icon"}},{"before":"bd008b763ae09863578a5ed3ba2b68fc0e924d82","after":"8ad4e58a32ba8c4ed02cf46375a9cbedd4f20e16","ref":"refs/heads/FW-6062","pushedAt":"2024-05-08T20:52:46.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"thetaPC","name":"Maria Hutt","path":"/thetaPC","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/13530427?s=80&v=4"},"commit":{"message":"chore(searchbar): run lint","shortMessageHtmlLink":"chore(searchbar): run lint"}},{"before":"14cf2edbbc160beefdff5f0f65436cc24f7a2a32","after":"bd008b763ae09863578a5ed3ba2b68fc0e924d82","ref":"refs/heads/FW-6062","pushedAt":"2024-05-08T20:51:45.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"thetaPC","name":"Maria Hutt","path":"/thetaPC","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/13530427?s=80&v=4"},"commit":{"message":"refactor(toggle): rotate only the default checked icon","shortMessageHtmlLink":"refactor(toggle): rotate only the default checked icon"}},{"before":"e5441e678bcdd6f739d334293d6a941896de5abf","after":"7c1a1f0fbe796080629504c9387b9c737b9f7812","ref":"refs/heads/FW-6098","pushedAt":"2024-05-08T20:40:11.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"brandyscarney","name":"Brandy Carney","path":"/brandyscarney","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6577830?s=80&v=4"},"commit":{"message":"chore: build","shortMessageHtmlLink":"chore: build"}},{"before":null,"after":"e5441e678bcdd6f739d334293d6a941896de5abf","ref":"refs/heads/FW-6098","pushedAt":"2024-05-08T20:31:35.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"brandyscarney","name":"Brandy Carney","path":"/brandyscarney","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6577830?s=80&v=4"},"commit":{"message":"test(input): add e2e tests for rectangular shape","shortMessageHtmlLink":"test(input): add e2e tests for rectangular shape"}},{"before":"e2a8046a33c734d24010a655b2701b1e06a71d1c","after":"14cf2edbbc160beefdff5f0f65436cc24f7a2a32","ref":"refs/heads/FW-6062","pushedAt":"2024-05-08T20:27:48.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"thetaPC","name":"Maria Hutt","path":"/thetaPC","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/13530427?s=80&v=4"},"commit":{"message":"refactor(select): combine lines","shortMessageHtmlLink":"refactor(select): combine lines"}},{"before":"3830bf82e4421c83e32c21362afb97ea310815c4","after":"e2a8046a33c734d24010a655b2701b1e06a71d1c","ref":"refs/heads/FW-6062","pushedAt":"2024-05-08T20:24:36.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"thetaPC","name":"Maria Hutt","path":"/thetaPC","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/13530427?s=80&v=4"},"commit":{"message":"refactor(searchbar): use backButtonIcon as default","shortMessageHtmlLink":"refactor(searchbar): use backButtonIcon as default"}},{"before":"1885f5e4d82fac3187fc9e654658c7aa035ed014","after":null,"ref":"refs/heads/FW-6097","pushedAt":"2024-05-08T20:21:52.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"thetaPC","name":"Maria Hutt","path":"/thetaPC","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/13530427?s=80&v=4"}},{"before":"fd14ddfec7bf8055ebc21dbabb32348f7c24f705","after":"7333376506afb2e18c97d6a007ac7e464ea635dc","ref":"refs/heads/ROU-4848","pushedAt":"2024-05-08T20:21:52.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"thetaPC","name":"Maria Hutt","path":"/thetaPC","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/13530427?s=80&v=4"},"commit":{"message":"fix(input): implement default shape for ionic theme (#29469)\n\nCo-authored-by: Brandy Carney ","shortMessageHtmlLink":"fix(input): implement default shape for ionic theme (#29469)"}},{"before":"0f0e23c2c01c29f62923ca123440261fd2a2c8a6","after":"1885f5e4d82fac3187fc9e654658c7aa035ed014","ref":"refs/heads/FW-6097","pushedAt":"2024-05-08T20:08:02.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"thetaPC","name":"Maria Hutt","path":"/thetaPC","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/13530427?s=80&v=4"},"commit":{"message":"test(input): update filename","shortMessageHtmlLink":"test(input): update filename"}},{"before":"0f8eeed5dba46d9c974a0802e6df206d7da52442","after":null,"ref":"refs/heads/FW-6192","pushedAt":"2024-05-08T20:05:59.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"brandyscarney","name":"Brandy Carney","path":"/brandyscarney","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6577830?s=80&v=4"}},{"before":"c78d2e6ec8ff0bc1951a5a3431f82a2346f7d351","after":"4dae03f2ac2132b0451ca7c43171ad49ca975ef2","ref":"refs/heads/FW-6191","pushedAt":"2024-05-08T20:05:59.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"brandyscarney","name":"Brandy Carney","path":"/brandyscarney","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6577830?s=80&v=4"},"commit":{"message":"feat(button): set default shape to soft for ios and round for md and ionic themes (#29404)\n\nIssue number: internal\r\n\r\n---------\r\n\r\n## What is the current behavior?\r\nThe `shape` property defaults to `\"soft\"` for `ios` and `\"round\"` for\r\nthe `md` and `ionic` themes.\r\n\r\n**Default button size**:\r\n\r\n| Property Value | CSS Value (`ionic`) | CSS Value (`ios`) | CSS Value\r\n(`md`) |\r\n| --------------- | ------ | ----------- | ----------- |\r\n| `undefined` | `8px` | `14px` | `4px` |\r\n| `\"round\"` | `999px` | unsupported | unsupported |\r\n| `\"rectangular\"` | `0px` | unsupported | unsupported |\r\n\r\n**Large button size**:\r\n\r\n| Property Value | CSS Value (`ionic`) | CSS Value (`ios`) | CSS Value\r\n(`md`) |\r\n| --------------- | ------ | ----------- | ----------- |\r\n| `undefined` | `8px` | `16px` | `4px` |\r\n\r\n**Small button size**:\r\n\r\n| Property Value | CSS Value (`ionic`) | CSS Value (`ios`) | CSS Value\r\n(`md`) |\r\n| --------------- | ------ | ----------- | ----------- |\r\n| `undefined` | `4px` | `6px` | `4px` |\r\n\r\n## What is the new behavior?\r\nThe `shape` property defaults to `undefined` which evaluates to the\r\n\"Soft\" shape for all themes.\r\n\r\n\r\n**Default button size**:\r\n\r\n| Property Value | CSS Value (`ionic`) | CSS Value (`ios`) | CSS Value\r\n(`md`) |\r\n| --------------- | ------- | ------ | -------- |\r\n| `\"soft\"` | `8px` | `6px` | `4px` |\r\n| `\"round\"` | `999px` | `999px` | `999px` |\r\n| `\"rectangular\"` | `0px` | `0px` | `0px` |\r\n\r\n**Large button size**:\r\n\r\n| Property Value | CSS Value (`ionic`) | CSS Value (`ios`) | CSS Value\r\n(`md`) |\r\n| --------------- | ------ | ----------- | ----------- |\r\n| `soft` | `8px` | `8px` | `4px` |\r\n\r\n**Small button size**:\r\n\r\n| Property Value | CSS Value (`ionic`) | CSS Value (`ios`) | CSS Value\r\n(`md`) |\r\n| --------------- | ------ | ----------- | ----------- |\r\n| `soft` | `4px` | `4px` | `4px` |\r\n\r\n- Adds support for the `\"soft\"` shape in the `ionic` theme using the\r\nexisting values for `undefined`\r\n- Adds support for the `\"rectangular\"` and `\"round\"` shapes in `ios` and\r\n`md` using `0px` and `999px` border radius\r\n- Sets the default shape property to `\"round\"` for the `ionic` and `md`\r\nthemes and `\"soft\"` for `ios` and updates the `border-radius` to apply\r\nto the shape classes instead of `:host`\r\n- Updates the `\"soft\"` shape border radius for `ios` in the various\r\nsizes to match the buttons created in SwiftUI (their \"rounded\" is our\r\n\"soft\"):\r\n\r\n![rounded-ios-buttons](https://github.com/ionic-team/ionic-framework/assets/6577830/230edf21-de68-4c41-9b89-8ea310ce42f2)\r\n- Fixed the icon only buttons in the `\"ionic\"` theme so that they are\r\nnot styled based on the size while always following the proper aspect\r\nratio. This was broken for the default size due to an incorrect padding\r\nvalue & I made it so we don't have to specify the padding for each size:\r\n\r\n| Before | After |\r\n| ---| ---|\r\n|\r\n![before](https://github.com/ionic-team/ionic-framework/assets/6577830/1e8d1a82-ad58-4372-be69-09175362c810)\r\n|\r\n![after](https://github.com/ionic-team/ionic-framework/assets/6577830/06cf6e22-a606-4ccc-ae4b-df69cf9c1e1e)\r\n|\r\n\r\n## Does this introduce a breaking change?\r\n\r\n- [x] Yes\r\n- [ ] No\r\n\r\nBREAKING CHANGE:\r\n\r\nThe `border-radius` of the `ios` and `md` button now defaults to `6px`\r\nand `999px` instead of `14px` and `4px`, respectively, in accordance\r\nwith the iOS and Material Design 3 guidelines. To revert to the previous\r\nappearance, set the `shape` to `\"soft\"` for `md` and override the\r\n`--border-radius` CSS variable for `ios` to `14px`, or set it to a\r\ndifferent value entirely.\r\n\r\n---------\r\n\r\nCo-authored-by: ionitron ","shortMessageHtmlLink":"feat(button): set default shape to soft for ios and round for md and …"}},{"before":"87f717f8fd2e1cf07ee21bb5dbcd088c097354d1","after":"0f0e23c2c01c29f62923ca123440261fd2a2c8a6","ref":"refs/heads/FW-6097","pushedAt":"2024-05-08T20:00:01.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"thetaPC","name":"Maria Hutt","path":"/thetaPC","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/13530427?s=80&v=4"},"commit":{"message":"Update core/src/components/input/test/shape/input.e2e.ts\n\nCo-authored-by: Brandy Carney ","shortMessageHtmlLink":"Update core/src/components/input/test/shape/input.e2e.ts"}}],"hasNextPage":true,"hasPreviousPage":false,"activityType":"all","actor":null,"timePeriod":"all","sort":"DESC","perPage":30,"cursor":"djE6ks8AAAAERR77DAA","startCursor":null,"endCursor":null}},"title":"Activity · ionic-team/ionic-framework"}