Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deprecation warning of setup.py check #109

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

bagerard
Copy link

@bagerard bagerard commented Jan 6, 2019

Inspired by how it got fixed in pyca/cryptography#4523
Fixes #108

@bagerard bagerard force-pushed the fix_deprecation_warning_setup_py_check branch from e6d486c to a7294c6 Compare January 12, 2019 12:40
@janluke
Copy link
Contributor

janluke commented Mar 25, 2019

This always gives an error after you've produced the doc in dist/docs, right?

Checking distribution dist/docs: InvalidDistribution: Unknown distribution format: 'docs'

@ionelmc
Copy link
Owner

ionelmc commented Jul 26, 2019

Yeah dist/docs is a problem. I wish there was another way of doing this. Twine, an upload tool, is the wrong place to do this check.

@ionelmc
Copy link
Owner

ionelmc commented Jul 26, 2019

Either way, even if twine could be the right tool the check env is not meant to build dists, and twine check would only test one of the dists - which is inadequate.

To really solve this pylibrary needs a way to automate publishing (and then piggyback twine check on top of that).

@ionelmc
Copy link
Owner

ionelmc commented Jul 26, 2019

Btw it was deprecated in this ninja change: pypa/readme_renderer#122 - devoid of any discussion or explanation.

@bagerard bagerard closed this Nov 11, 2019
@ionelmc
Copy link
Owner

ionelmc commented Nov 11, 2019

This is still on my todo list. Just need to figure out a clean way do do it cross-platform (like using some tmp dir) without mucking about in the dist folder which might have other dists there.

@ionelmc ionelmc reopened this Nov 11, 2019
@Querela
Copy link
Contributor

Querela commented Dec 24, 2020

This always gives an error after you've produced the doc in dist/docs, right?

Checking distribution dist/docs: InvalidDistribution: Unknown distribution format: 'docs'

You could always specify a file extension pattern, and then it will work (with ignoring docs) ...
E.g.: twine check dist/*.{whl,gz}
I found that twine check is slightly more strict than python setup.py check [...].
But it might still check all possible distributions regardless of environment, so not sure in case of errors.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deprecation warning when using setup.py check through tox
5 participants